-
Notifications
You must be signed in to change notification settings - Fork 4
fix(email): address postguard#197 deliverability + show disclosed signer name #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2516329
fix(email): address postguard#197 deliverability + show disclosed sig…
rubenhensen 7f03943
build: copy build.rs in Dockerfile and apply rustfmt
rubenhensen 64aea4d
fix(email): address dobby review on disclosed-name flow
rubenhensen 7d3aac0
feat(email): render firstName+lastName from passport/idcard/drivingli…
rubenhensen 824c9f3
fix(email): use 'PostGuard' as sender display when no name is disclosed
rubenhensen a691222
style: cargo fmt
rubenhensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| fn main() { | ||
| println!("cargo:rerun-if-changed=Cargo.lock"); | ||
|
|
||
| let lock = std::fs::read_to_string("Cargo.lock").expect("Cargo.lock not readable"); | ||
| let version = lock | ||
| .split("[[package]]") | ||
| .find_map(|block| { | ||
| let mut name = None; | ||
| let mut ver = None; | ||
| for line in block.lines() { | ||
| if let Some(rest) = line.strip_prefix("name = \"") { | ||
| name = rest.strip_suffix('"'); | ||
| } | ||
| if let Some(rest) = line.strip_prefix("version = \"") { | ||
| ver = rest.strip_suffix('"'); | ||
| } | ||
| } | ||
| if name == Some("pg-core") { | ||
| ver | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .expect( | ||
| "pg-core entry not found in Cargo.lock — PG_CORE_VERSION feeds the \ | ||
| X-PostGuard mail header that the Outlook add-in's OnMessageRead \ | ||
| launch event filters on (see src/email.rs::XPostGuard).", | ||
| ); | ||
|
|
||
| println!("cargo:rustc-env=PG_CORE_VERSION={}", version); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Code review] Splitting
Cargo.lockon the literal[[package]]is fragile if a future lockfile format ever includes that substring inside a quoted string (no such case today). A tiny TOML parse (orcargo_metadata) would be safer; not blocking.