Bump dependencies to current major versions#2
Merged
Merged
Conversation
- reqwest 0.11 -> 0.12 - thiserror 1.0 -> 2.0 - qrcode 0.12 -> 0.14 - serial_test 0.5 -> 3.2 - serde, serde_json, url, tokio, tokio-test bumped to latest minor Existing usage of all bumped crates is API-compatible. Internal tests and examples updated to import from the renamed `irmars` crate (was `irma`).
There was a problem hiding this comment.
Reviewed the diff and ran the suite locally.
Verified
cargo build --tests --examples— cleancargo test --lib— 6/6 passcargo fmt --all -- --check— clean- Clippy CI job already green
- Diff matches the description: deps bumped, examples + integration tests switched from
irma::toirmars::
Notes
reqwest 0.12leaks into the public API viaError::NetworkError(#[from] reqwest::Error), as called out in the PR body. Downstream (postguard) will need a matching bump — that caveat is correctly flagged.thiserror 2.0is a drop-in for the#[from]/#[error("…")]usage insrc/error.rs; no syntax in this repo touches the breaking-change surface.qrcode 0.14andserial_test 3.2are only in dev-deps/examples and still compile/run.
Integration tests (RUN_INTEGRATION_TESTS=1) need a live irma server, so not run here — flagged in the test plan already.
LGTM, ready to ship before the first publish.
This was referenced May 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes all dependencies before the first publish of the fork.
#[from]/#[error]work#[serial]worksAlso updates internal tests and examples to
use irmars::...(the package was renamed fromirmatoirmarsin the prior PR).pg-coreis the public re-export ofreqwest::ErrorviaError::NetworkError(#[from] reqwest::Error), so consumers (postguard) that catch this variant will need their ownreqwest = "0.12"bump for the types to align.Test plan
cargo build --tests --examplessucceedscargo test --lib-> 6 passedcargo fmt --checkcleancargo clippy --all-targetsshows only pre-existing warnings (not introduced here)RUN_INTEGRATION_TESTS=1) — require local irma server, not run in this PR