ci: bump irmago to v0.19.2 and point scheme download at schemes.yivi.app#5
Merged
Conversation
The privacybydesign.foundation scheme manager URL now 301-redirects to schemes.yivi.app, but the v0.8.0 irma binary fails TLS validation on the legacy domain before the redirect resolves, so 'irma scheme download' with no args fails with a transport error. Pass the new URLs explicitly to sidestep the dead default.
v0.8.0 is from 2019 and has the old scheme URLs compiled in. Asset filename also changed from irma-master-linux-amd64 to irma-linux-amd64. Lift the version into an IRMAGO_VERSION env to make future bumps a one-line change.
rubenhensen
changed the title
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. CI is green on the latest commit, and the change is well-scoped to the CI workflow.
What was verified:
https://schemes.yivi.app/irma-demo/description.xmland.../pbdf/description.xmlboth return 200.- New asset
https://github.com/privacybydesign/irmago/releases/download/v0.19.2/irma-linux-amd64resolves. Integration testsjob passes on run 26024555963 with the bumped binary + explicit scheme URLs.
Nice touches: lifting IRMAGO_VERSION into an env var, and the inline comment explaining why the URLs are passed explicitly rather than relying on compiled-in defaults — that one would have saved someone debugging time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes for the integration-test job:
1. Bump irmago server v0.8.0 -> v0.19.2
v0.8.0 was released in 2019. Asset filename also changed from `irma-master-linux-amd64` to `irma-linux-amd64`. Lifted into an `IRMAGO_VERSION` env so future bumps are a one-line edit.
2. Pass explicit scheme URLs to `irma scheme download`
Even with the new binary, pinning the URL here keeps CI independent of any future default-URL drift in irmago. The legacy `privacybydesign.foundation` host now 301-redirects to `schemes.yivi.app` (IRMA was rebranded to Yivi). The old v0.8.0 binary failed TLS validation on the legacy domain before the redirect could resolve, which is what was breaking the CI run linked from this PR's previous comments.
Verified live:
Test plan