docs: pin source links to full commit hashes#63
Merged
Conversation
- cryptify.md: pin src/main.rs link to commit 2a6dac1 instead of /blob/main/ - pg-sveltekit.md: expand short hashes (2b29c1ba18) to full 40-char SHAs - pg-sveltekit.md: align +page.svelte handleSend snippet with source at L36-L65 Closes #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57.
Three source links in
docs/repos/violated the full-40-char-commit-hash convention:docs/repos/cryptify.md:89— repointed from/blob/main/src/main.rsto commit2a6dac195ef4efae8758084aaacab04bc9c94206(latest commit touching that file).docs/repos/pg-sveltekit.md:124— expanded short hash2b29c1ba18to the full SHA2b29c1ba18be39d89380a9dd8dd4d3370e17e0b2. Snippet content unchanged; verified against source.docs/repos/pg-sveltekit.md:159— same hash expansion. While verifying, the in-dochandleSendsnippet was missing two lines that exist at+page.svelteL36-L65 (errorMessage = '';reset and aconsole.error(...)call). Added them so the snippet faithfully matches the pinned range.Verification
curl -sIreturns 200 for all three pinned URLs.+page.server.tsand+page.svelteat the full SHA — content matches the docs snippets line-for-line after the small+page.sveltecorrection.d6c7f01consolidation because the API form changed (encryptAndSendwrapper era vs. currentpg.open({uuid}).decrypt(...)). A full rewrite against the current API is a separate, larger piece of work.Reviewer quickstart
```
git fetch origin && git checkout dobby/pin-source-link-hashes && npm install && npm run docs:build
```
Local build succeeded in 24s.