fix simple mis-matched function prototype and definitions.

most of these are like, eg

   void foo(int[2]);

with either of these

   void foo(int*) { ... }
   void foo(int[]) { ... }

in some cases (such as stat or utimes* calls found in our header files),
we now match standard definition from opengroup.

found by GCC 12.

Author: mrgtwentythree

bin/ed/cbc.c

@@ -1,4 +1,4 @@
-/*	$NetBSD: cbc.c,v 1.25 2018/02/08 09:05:16 dholland Exp $	*/
+/*	$NetBSD: cbc.c,v 1.26 2023/08/01 07:04:14 mrg Exp $	*/
 
 /* cbc.c: This file contains the encryption routines for the ed line editor */
 /*-
@@ -72,7 +72,7 @@
 #if 0
 static char *rcsid = "@(#)cbc.c,v 1.2 1994/02/01 00:34:36 alm Exp";
 #else
-__RCSID("$NetBSD: cbc.c,v 1.25 2018/02/08 09:05:16 dholland Exp $");
+__RCSID("$NetBSD: cbc.c,v 1.26 2023/08/01 07:04:14 mrg Exp $");
 #endif
 #endif /* not lint */
 
@@ -145,7 +145,7 @@ static int des_n = 0;		/* index for put_des_char/get_des_char */
 static void des_error(const char *);
 static int hex_to_binary(int, int);
 static void expand_des_key(char *, char *);
-static void set_des_key(char *);
+static void set_des_key(Desbuf);
 static int cbc_decode(char *, FILE *);
 static int cbc_encode(char *, int, FILE *);
 #endif

crypto/external/bsd/netpgp/dist/src/netpgpverify/sha2.c

@@ -1,4 +1,4 @@
-/* $NetBSD: sha2.c,v 1.4 2018/08/13 09:54:19 christos Exp $ */
+/* $NetBSD: sha2.c,v 1.5 2023/08/01 07:04:14 mrg Exp $ */
 /*	$KAME: sha2.c,v 1.9 2003/07/20 00:28:38 itojun Exp $	*/
 
 /*
@@ -588,7 +588,7 @@ netpgpv_SHA224_256_Final(uint8_t digest[], NETPGPV_SHA256_CTX *context, size_t l
 }
 
 int
-netpgpv_SHA256_Final(uint8_t digest[], NETPGPV_SHA256_CTX *context)
+netpgpv_SHA256_Final(uint8_t digest[32], NETPGPV_SHA256_CTX *context)
 {
 	return netpgpv_SHA224_256_Final(digest, context, SHA256_DIGEST_LENGTH);
 }
@@ -622,7 +622,7 @@ netpgpv_SHA224_Transform(NETPGPV_SHA224_CTX *context, const uint32_t *data)
 }
 
 int
-netpgpv_SHA224_Final(uint8_t digest[], NETPGPV_SHA224_CTX *context)
+netpgpv_SHA224_Final(uint8_t digest[28], NETPGPV_SHA224_CTX *context)
 {
 	return netpgpv_SHA224_256_Final(digest, (NETPGPV_SHA256_CTX *)context,
 	    SHA224_DIGEST_LENGTH);
@@ -915,7 +915,7 @@ netpgpv_SHA512_Last(NETPGPV_SHA512_CTX *context)
 }
 
 int
-netpgpv_SHA512_Final(uint8_t digest[], NETPGPV_SHA512_CTX *context)
+netpgpv_SHA512_Final(uint8_t digest[64], NETPGPV_SHA512_CTX *context)
 {
 	size_t i;
 
@@ -962,7 +962,7 @@ netpgpv_SHA384_Transform(NETPGPV_SHA512_CTX *context, const uint64_t *data)
 }
 
 int
-netpgpv_SHA384_Final(uint8_t digest[], NETPGPV_SHA384_CTX *context)
+netpgpv_SHA384_Final(uint8_t digest[48], NETPGPV_SHA384_CTX *context)
 {
 	size_t i;
 

dist/pf/sbin/pfctl/pfctl_radix.c

@@ -1,4 +1,4 @@
-/*	$NetBSD: pfctl_radix.c,v 1.5 2008/06/18 09:06:26 yamt Exp $	*/
+/*	$NetBSD: pfctl_radix.c,v 1.6 2023/08/01 07:04:14 mrg Exp $	*/
 /*	$OpenBSD: pfctl_radix.c,v 1.27 2005/05/21 21:03:58 henning Exp $ */
 
 /*
@@ -52,7 +52,7 @@
 
 extern int dev;
 
-static int	 pfr_next_token(char buf[], FILE *);
+static int	 pfr_next_token(char buf[BUF_SIZE], FILE *);
 
 
 int

external/bsd/libarchive/dist/libarchive/archive_read_support_format_warc.c

@@ -127,7 +127,7 @@ static int _warc_skip(struct archive_read *a);
 static int _warc_rdhdr(struct archive_read *a, struct archive_entry *e);
 
 /* private routines */
-static unsigned int _warc_rdver(const char buf[10], size_t bsz);
+static unsigned int _warc_rdver(const char *buf, size_t bsz);
 static unsigned int _warc_rdtyp(const char *buf, size_t bsz);
 static warc_string_t _warc_rduri(const char *buf, size_t bsz);
 static ssize_t _warc_rdlen(const char *buf, size_t bsz);

external/bsd/libevent/dist/util-internal.h

@@ -1,4 +1,4 @@
-/*	$NetBSD: util-internal.h,v 1.7 2021/04/10 19:18:45 rillig Exp $	*/
+/*	$NetBSD: util-internal.h,v 1.8 2023/08/01 07:04:14 mrg Exp $	*/
 
 /*
  * Copyright (c) 2007-2012 Niels Provos and Nick Mathewson
@@ -305,7 +305,7 @@ int evutil_socket_connect_(evutil_socket_t *fd_ptr, const struct sockaddr *sa, i
 int evutil_socket_finished_connecting_(evutil_socket_t fd);
 
 EVENT2_EXPORT_SYMBOL
-int evutil_ersatz_socketpair_(int, int , int, evutil_socket_t[]);
+int evutil_ersatz_socketpair_(int, int , int, evutil_socket_t[2]);
 
 int evutil_resolve_(int family, const char *hostname, struct sockaddr *sa,
     ev_socklen_t *socklen, int port);

external/bsd/ntp/dist/sntp/libevent/util-internal.h

@@ -1,4 +1,4 @@
-/*	$NetBSD: util-internal.h,v 1.6 2020/05/25 20:47:33 christos Exp $	*/
+/*	$NetBSD: util-internal.h,v 1.7 2023/08/01 07:04:14 mrg Exp $	*/
 
 /*
  * Copyright (c) 2007-2012 Niels Provos and Nick Mathewson
@@ -267,7 +267,7 @@ int evutil_socket_connect_(evutil_socket_t *fd_ptr, struct sockaddr *sa, int soc
 
 int evutil_socket_finished_connecting_(evutil_socket_t fd);
 
-int evutil_ersatz_socketpair_(int, int , int, evutil_socket_t[]);
+int evutil_ersatz_socketpair_(int, int , int, evutil_socket_t[2]);
 
 int evutil_resolve_(int family, const char *hostname, struct sockaddr *sa,
     ev_socklen_t *socklen, int port);

external/bsd/nvi/dist/ex/ex_subst.c

@@ -1,4 +1,4 @@
-/*	$NetBSD: ex_subst.c,v 1.4 2014/01/26 21:43:45 christos Exp $ */
+/*	$NetBSD: ex_subst.c,v 1.5 2023/08/01 07:04:14 mrg Exp $ */
 /*-
  * Copyright (c) 1992, 1993, 1994
  *	The Regents of the University of California.  All rights reserved.
@@ -16,7 +16,7 @@
 static const char sccsid[] = "Id: ex_subst.c,v 10.50 2002/02/09 21:18:23 skimo Exp  (Berkeley) Date: 2002/02/09 21:18:23 ";
 #endif /* not lint */
 #else
-__RCSID("$NetBSD: ex_subst.c,v 1.4 2014/01/26 21:43:45 christos Exp $");
+__RCSID("$NetBSD: ex_subst.c,v 1.5 2023/08/01 07:04:14 mrg Exp $");
 #endif
 
 #include <sys/types.h>
@@ -1320,7 +1320,7 @@ re_error(SCR *sp, int errcode, regex_t *preg)
  * 	Do the substitution for a regular expression.
  */
 static int
-re_sub(SCR *sp, CHAR_T *ip, CHAR_T **lbp, size_t *lbclenp, size_t *lblenp, regmatch_t *match)
+re_sub(SCR *sp, CHAR_T *ip, CHAR_T **lbp, size_t *lbclenp, size_t *lblenp, regmatch_t match[10])
 
 	           			/* Input line. */
 

external/bsd/ppp/dist/pppd/chap_ms.c

@@ -1,4 +1,4 @@
-/*	$NetBSD: chap_ms.c,v 1.5 2021/01/09 16:39:28 christos Exp $	*/
+/*	$NetBSD: chap_ms.c,v 1.6 2023/08/01 07:04:15 mrg Exp $	*/
 
 /*
  * chap_ms.c - Microsoft MS-CHAP compatible implementation.
@@ -81,7 +81,7 @@
 #define RCSID	"Id: chap_ms.c,v 1.38 2007/12/01 20:10:51 carlsonj Exp "
 static const char rcsid[] = RCSID;
 #else
-__RCSID("$NetBSD: chap_ms.c,v 1.5 2021/01/09 16:39:28 christos Exp $");
+__RCSID("$NetBSD: chap_ms.c,v 1.6 2023/08/01 07:04:15 mrg Exp $");
 #endif
 
 #ifdef CHAPMS
@@ -108,7 +108,8 @@ __RCSID("$NetBSD: chap_ms.c,v 1.5 2021/01/09 16:39:28 christos Exp $");
 
 static void	ascii2unicode (char[], int, u_char[]);
 static void	NTPasswordHash (u_char *, int, u_char[MD4_SIGNATURE_SIZE]);
-static void	ChallengeResponse (u_char *, u_char *, u_char[24]);
+static void	ChallengeResponse (u_char *, u_char[MD4_SIGNATURE_SIZE],
+				u_char[24]);
 static void	ChapMS_NT (u_char *, char *, int, u_char[24]);
 static void	ChapMS2_NT (u_char *, u_char[16], char *, char *, int,
 				u_char[24]);
@@ -923,7 +924,7 @@ ChapMS(u_char *rchallenge, char *secret, int secret_len,
 void
 ChapMS2(u_char *rchallenge, u_char *PeerChallenge,
 	char *user, char *secret, int secret_len, unsigned char *response,
-	u_char authResponse[], int authenticator)
+	u_char authResponse[MS_AUTH_RESPONSE_LENGTH+1], int authenticator)
 {
     /* ARGSUSED */
     u_char *p = &response[MS_CHAP2_PEER_CHALLENGE];

games/sail/dr_5.c

@@ -1,4 +1,4 @@
-/*	$NetBSD: dr_5.c,v 1.14 2009/03/14 22:52:52 dholland Exp $	*/
+/*	$NetBSD: dr_5.c,v 1.15 2023/08/01 07:04:15 mrg Exp $	*/
 
 /*
  * Copyright (c) 1983, 1993
@@ -34,15 +34,15 @@
 #if 0
 static char sccsid[] = "@(#)dr_5.c	8.2 (Berkeley) 4/28/95";
 #else
-__RCSID("$NetBSD: dr_5.c,v 1.14 2009/03/14 22:52:52 dholland Exp $");
+__RCSID("$NetBSD: dr_5.c,v 1.15 2023/08/01 07:04:15 mrg Exp $");
 #endif
 #endif /* not lint */
 
 #include <sys/types.h>
 #include "extern.h"
 
 void
-subtract(struct ship *from, struct ship *fromcap, int totalfrom, int *crewfrom,
+subtract(struct ship *from, struct ship *fromcap, int totalfrom, int crewfrom[3],
 	 int pcfrom)
 {
 	int n;
@@ -66,7 +66,7 @@ subtract(struct ship *from, struct ship *fromcap, int totalfrom, int *crewfrom,
 }
 
 int
-mensent(struct ship *from, struct ship *to, int *crew, struct ship **captured,
+mensent(struct ship *from, struct ship *to, int crew[3], struct ship **captured,
 	int *pc, int isdefense)
 {					/* returns # of crew squares sent */
 	int men = 0;

include/md2.h

@@ -1,4 +1,4 @@
-/*	$NetBSD: md2.h,v 1.7 2016/07/01 16:42:46 christos Exp $	*/
+/*	$NetBSD: md2.h,v 1.8 2023/08/01 07:04:15 mrg Exp $	*/
 
 #ifndef _MD2_H_
 #define _MD2_H_
@@ -21,10 +21,10 @@ __BEGIN_DECLS
 void	MD2Init(MD2_CTX *);
 void	MD2Update(MD2_CTX *, const unsigned char *, unsigned int);
 void	MD2Final(unsigned char[16], MD2_CTX *);
-char	*MD2End(MD2_CTX *, char *);
+char	*MD2End(MD2_CTX *, char[MD2_DIGEST_STRING_LENGTH]);
 char	*MD2File(const char *, char *);
 char	*MD2FileChunk(const char *, char *, off_t, off_t);
-char	*MD2Data(const unsigned char *, size_t, char *);
+char	*MD2Data(const unsigned char *, size_t, char[MD2_DIGEST_STRING_LENGTH]);
 __END_DECLS
 
 #endif /* _MD2_H_ */