fix: add phased servestead web plan and setup coverage#38
Conversation
nipuna-perera
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4014c86f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| model.err = "profile store is unavailable" | ||
| return model | ||
| } | ||
| options, err := model.optionsForSelectedProfile() |
There was a problem hiding this comment.
When Ctrl+S is pressed from the Advanced values screen, this call builds options with optionsForSelectedProfile(), which takes Name, InitialSSHUser, and AdminUser from the already-saved profile instead of the edited advanced inputs. In that scenario the UI returns to the dashboard with “Saved profile settings,” but changes to the profile name or SSH users are silently discarded; those advanced fields need to be read from model.advanced before persisting.
Useful? React with 👍 / 👎.
1 participant
Summary
setup.go.setup_test.gofor the revised setup behavior.Testing