Skip to content

Add flag to enable processing and uploading of native symbols to Firebase servers.#13

Merged
manuq merged 2 commits into2022.09.04-endlessfrom
enable-crashlytics-native-symbol-upload
Nov 3, 2022
Merged

Add flag to enable processing and uploading of native symbols to Firebase servers.#13
manuq merged 2 commits into2022.09.04-endlessfrom
enable-crashlytics-native-symbol-upload

Conversation

@xcho1
Copy link
Copy Markdown

@xcho1 xcho1 commented Nov 3, 2022

No description provided.

@erikos erikos requested review from dylanmccall and manuq November 3, 2022 13:44
Copy link
Copy Markdown

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for the CI to pass before merging.

Comment on lines +892 to +894
ap.add_argument('--enable-crashlytics-native-symbol-upload', dest='enable_crashlytics_native_symbol_upload',
action='store-true',
help='Enable processing and uploading of native symbols to Firebase servers.')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +95 to +99
{$ if args.enable_crashlytics_native_symbol_upload -%}
firebaseCrashlytics {
nativeSymbolUploadEnabled true
}
{%- endif %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manuq manuq merged commit f9f0f81 into 2022.09.04-endless Nov 3, 2022
@manuq manuq deleted the enable-crashlytics-native-symbol-upload branch November 3, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants