Sokoban: Fix player movement during introductory dialogue #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlealarcViva
changed the title
AlealarcViva
changed the title
|
Test build no longer available. |
manuq
requested changes
Aug 27, 2025
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This fixes the bug! Excellent!
Two things before merging:
- Please fix the coding styles by applying my suggestions.
- The pull request title is good! But please improve the pull request description. Here are our guidelines: https://github.com/endlessm/threadbare/blob/main/docs/CONTRIBUTING.md#git-commit-messages-and-pull-request-descriptions . You already have a good description of the problem and what's the solution you made in your planning sheet, so you can use it for the pull request description by translating some parts to English.
| func _unhandled_input(event: InputEvent)-> void: | ||
| # Handle newly-pressed input directions | ||
| if Input.is_action_just_pressed(action_up): | ||
| if event.is_action_pressed(action_up): |
Collaborator
There was a problem hiding this comment.
Good, InputEvent doesn't have is_action_just_pressed() or is_action_just_released so these changes are correct.
|
|
||
|
|
||
| func _process(delta: float) -> void: | ||
| func _unhandled_input(event: InputEvent)-> void: |
Collaborator
There was a problem hiding this comment.
Just a detail: the coding style is to have a space character between the ->:
Suggested change
| func _unhandled_input(event: InputEvent)-> void: | |
| func _unhandled_input(event: InputEvent) -> void: |
You can read about the coding style in https://github.com/endlessm/threadbare/blob/main/docs/CONTRIBUTING.md#coding-style . It also tells you how to enforce it when you commit.
And also the coding style checks run automatically for each pull request. Here you can see that it fixed this and the issue below (2 blank lines before func) https://github.com/endlessm/threadbare/actions/runs/17248081317/job/49005301658?pr=1124
scenes/eternal_loom_sokoban/components/system/input/directional_input.gd
Show resolved
Hide resolved
Previously, the player could still move during the introductory dialogue at the beginning of the first Sokoban puzzle. This happened because input was handled in `_process()` instead of `_unhandled_input()`, contrary to Dialogue Manager’s documentation. In the main game, the Player was already migrated to `_unhandled_input` (commit 58e81c9), so Sokoban should behave consistently. This change updates the Sokoban Player script to handle input through `_unhandled_input()` and blocks player control while dialogue is active. Once the dialogue finishes, control is restored normally. Success criteria: - The player cannot move while the dialogue is active. - Player control is enabled only after the dialogue ends. - Input handling in Sokoban is now consistent with the rest of the game. - No regressions occur in normal Sokoban gameplay after dialogue. Fixes endlessm#493
manuq
changed the title
manuq
reviewed
Aug 28, 2025
scenes/eternal_loom_sokoban/components/system/input/directional_input.gd
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the player could still move during the introductory
dialogue at the beginning of the first Sokoban puzzle. This happened
because input was handled in
_process()instead of_unhandled_input(),contrary to Dialogue Manager’s documentation. In the main game, the
Player was already migrated to
_unhandled_input9cbeae3,so Sokoban should behave consistently.
This change updates the Sokoban Player script to handle input
through
_unhandled_input()and blocks player control while dialogueis active. Once the dialogue finishes, control is restored normally.
Success criteria:
Fixes #493