Vertical wipe transition between LoreQuest ink combat rounds #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build no longer available. |
manuq
reviewed
Sep 3, 2025
Comment on lines
11
to
12
| enum Effect { | ||
| FADE, LEFT_TO_RIGHT_WIPE, RIGHT_TO_LEFT_WIPE, RADIAL, TOP_TO_BOTTOM_WIPE, BOTTOM_TO_TOP_WIPE |
Collaborator
There was a problem hiding this comment.
Suggested change
| enum Effect { | |
| FADE, LEFT_TO_RIGHT_WIPE, RIGHT_TO_LEFT_WIPE, RADIAL, TOP_TO_BOTTOM_WIPE, BOTTOM_TO_TOP_WIPE | |
| enum Effect { | |
| FADE, LEFT_TO_RIGHT_WIPE, RIGHT_TO_LEFT_WIPE, RADIAL, TOP_TO_BOTTOM_WIPE, BOTTOM_TO_TOP_WIPE |
Collaborator
There was a problem hiding this comment.
@DonSeja06 great work! I think if you commit my suggestion above the check will pass. It removes trailing whitespace.
manuq
approved these changes
Sep 3, 2025
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
This works like a charm! I played levels 1 to 3 of the ink combat and the new vertical transitions work very well.
Also great work describing your changes in the pull request title and description!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new vertical wipe transitions have been added to improve navigation between ink combat rounds. These transitions help visually connect the rounds, since they are arranged vertically.
The enum Effect in transitions.gd now includes TOP_TO_BOTTOM_WIPE and BOTTOM_TO_TOP_WIPE, each wired to a new texture in res://scenes/globals/scene_switcher/transitions/.
Teleporters in the first two ink combat rounds are configured to use the appropriate vertical wipe.
Fix #790