Sokoban HUD: Don't override mouse cursor shape #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The “Z” key indicator in the Sokoban input hints HUD had its mouse cursor shape set to CURSOR_POINTING_HAND: > Pointing hand cursor. Usually used to indicate the pointer is over a link or > other interactable item. But this icon isn't interactable. This has been set this way since commit a52f9b0 when the Sokoban input hints were added. I'm sure this was not intentional. Unset it.
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/wjt/sokoban-hud-don-t-override-mouse-cursor-shape. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “Z” key indicator in the Sokoban input hints HUD had its mouse cursor shape
set to CURSOR_POINTING_HAND:
But this icon isn't interactable.
This has been set this way since commit a52f9b0
when the Sokoban input hints were added. I'm sure this was not intentional.
Unset it.