Intro: Play dialogue at normal speed #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the intro dialogue to not start until the fade-in from the previous
scene has finished.
Previously this was done by playing an animation that does nothing for 1 second.
We could instead use Godot Dialogue Manager's built-in syntax for waiting:
do wait(1.0)
but we can do even better. Wait for the Transitions.finished signal, but ony if
a transition is running. This is the same pattern used in a couple of other
places.
(Arguably Cinematic should do this automatically but that's a bigger change.)
The dialogue in the intro is set to play at half speed. I added this way back in March when I added this dialogue: #46 but there's no explanation there for why I made it half speed. Play it at the normal speed.
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/intro-dialogue-normal-speed. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Sep 30, 2025
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Nice to also use a signal for the transition waiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialogue in the intro is set to play at half speed. I added this way back in March when I added this dialogue #46 but there's no explanation there for why I made it half speed.
Play it at the normal speed.
Also, simplify how we wait for the fade-in to finish before starting the intro dialogue.