shjourney: Replace xylophone sound effects #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the main game, we have new, better-sounding sequence puzzle sounds. And unlike the xylophone samples that were used before, we have a full scale and a half, including all semitones. Replace the xylophone sounds in the dragon puzzle with handbell sounds. Change the scale from C major (C D E F G A) to C minor (C D D♯=E♭ F G G♯=A♭): this matches the background music in this level, which is in C minor.
Member
Author
|
@xXLeopoldoXx and team: please can you review this change? |
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/shjourney-replace-xylophone-samples. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Contributor
Of course @wjt , we will review it and adapt it |
Member
Author
|
No need to adapt: if it looks good, give it an approving review! The other reason for this change is that in #1204 I plan to remove the xylophone noises |
Contributor
I understand, I tried the minigame and everything looks fine @wjt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the main game, we have new, better-sounding sequence puzzle sounds. And unlike the xylophone samples that were used before, we have a full scale and a half, including all semitones.
Replace the xylophone sounds in the dragon puzzle with handbell sounds. Change the scale from C major (C D E F G A) to C minor (C D D♯=E♭ F G G♯=A♭): this matches the background music in this level, which is in C minor.