Remove wobble hints from sequence puzzle #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These hints are supposed to gently point the player in the right direction when they are stuck. But now: - The musician just tells you the answer if you keep talking to him; - You can interact with the hints and see the answer. So this is unnecessary, and actually it confuses the matter because the wobble hints can play while another rock is being sounded by the sign demoing the sequence: I've seen people being confused by this in playtesting. Remove the wobble hint logic, and the SequencePuzzleObject.wobble_silently() method. I left the code in SequencePuzzleObject.play() to optionally play the animation without sound, in case this is useful somehow. Resolves #686
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/wjt/remove-wobble-hints-from-sequence-puzzle. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hints are supposed to gently point the player in the right
direction when they are stuck. But now:
So this is unnecessary, and actually it confuses the matter because the
wobble hints can play while another rock is being sounded by the sign
demoing the sequence: I've seen people being confused by this in
playtesting.
Remove the wobble hint logic, and the
SequencePuzzleObject.wobble_silently() method. I left the code in
SequencePuzzleObject.play() to optionally play the animation without
sound, in case this is useful somehow.
Resolves #686