NO_EDIT_combat: Fix visual issues on non–16:9 aspect ratios #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the Stone (TileMapLayer) node by adding additional tiles around the combat arena to cover exposed areas. - Updated the Camera2D limits so the camera stays centered within the intended playable combat space. fix: #1605
|
Play this branch at https://play.threadbare.game/branches/endlessm/issue_1605. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Nov 17, 2025
Comment on lines
-106
to
+107
| limit_right = 2048 | ||
| limit_bottom = 2048 | ||
| limit_right = 960 | ||
| limit_bottom = 640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in the NO_EDIT_combat scene (
NO_EDIT_combat.tscn) where empty or unintended areas became visible when using aspect ratios different from 16:9 (such as 21:9, 4:3, or 5:4).Additional tiles were added to the
StoneTileMap layer to cover exposed borders, and theCamera2Dlimits were updated so the camera remains properly centered within the intended combat area across all supported aspect ratios.You can test the scene directly here:
Play NO_EDIT_combat
resolves: #1605