NO_EDIT_sequence_puzzle: Fix visual issues on non–16:9 aspect ratios

[russell-cj]

This pull request fixes an issue in the NO_EDIT_sequence_puzzle scene (NO_EDIT_sequence_puzzle.tscn) where out-of-bounds or undeveloped regions became visible when using aspect ratios different from 16:9 (such as 21:9 or 4:3).

A new Void TileMap layer was added to fill the outer edges of the scene, the Camera2D limits were updated to keep the puzzle centered, and the Grass and Sand tiles were slightly adjusted to match the new background. These changes ensure the entire puzzle area stays visually contained across all supported aspect ratios.

You can test the scene directly here:
Play NO_EDIT_sequence_puzzle

resolves: #1606

[github-actions]

Play this branch at https://play.threadbare.game/branches/endlessm/issue_1606.

(This launches the game from the start, not directly at the change(s) in this pull request.)

[russell-cj]

Hi @manuq , @wjt , @jgbourque , @Stregoica777
I created this PR taking into account the suggestions provided by the Learning team. It is mainly meant to give you a visual representation of how I interpreted the idea. As suggested, I only added a single node. I did modify the Camera2D node, but if the team decides that the camera should not be changed, I can restore it to its original state without any problem.

[manuq]

@russell-cj thanks!

@jgbourque can you please confirm that this is what we want? And if so, do we want the same for the intro and outro? I ask because a different solution has landed for the intro (enlarging the background).

[jgbourque]

Simply enlarging the background or I believe, as @russell-cj has done with the Stealth template: adding additional stone to expand that walled in look and cover the gray missing tiles is good I think.

But in the case of the Sequence puzzle, it might make more sense to just copy the intro.tscn solution of enlarging the background. That way the path the player walks in the cut scene has the appearance of continuing off screen instead of looking like it just leads to the void and ends abruptly on either side.

[russell-cj]

@russell-cj thanks!

@jgbourque can you please confirm that this is what we want? And if so, do we want the same for the intro and outro? I ask because a different solution has landed for the intro (enlarging the background).

Hi @manuq ,
Sure — if the background ends up showing empty space, then the solutions that have already landed across the different NO_EDIT levels would need to be updated to stay consistent. I'm keeping that in mind moving forward.

[russell-cj]

Simply enlarging the background or I believe, as @russell-cj has done with the Stealth template: adding additional stone to expand that walled in look and cover the gray missing tiles is good I think.

But in the case of the Sequence puzzle, it might make more sense to just copy the intro.tscn solution of enlarging the background. That way the path the player walks in the cut scene has the appearance of continuing off screen instead of looking like it just leads to the void and ends abruptly on either side.

Hi, @jgbourque
Perfect, I’ll apply the same approach that was already implemented in the solutions that have landed.

Taking into account that in the case of the intro, only the grass was extended because it’s a cinematic and the player doesn’t interact with the map.
On the other hand, scenes like the combat one are different: the rocks act as colliders and the player does move within the level. For that reason, simply filling the empty space wouldn’t be enough in this case; it’s necessary to add collisions or use tiles that act as colliders since the player is moving around the map.

One option to resolve this could be adding colliders or using water without the foam animation —it works well, keeps the scene clean, and still uses only a single additional node, similar to what was done in the empty-space solution.

[manuq]

Perfect, I’ll apply the same approach that was already implemented in the solutions that have landed.

Taking into account that in the case of the intro, only the grass was extended because it’s a cinematic and the player doesn’t interact with the map.

On the other hand, scenes like the combat one are different: the rocks act as colliders and the player does move within the level. For that reason, simply filling the empty space wouldn’t be enough in this case; it’s necessary to add collisions or use tiles that act as colliders since the player is moving around the map.

One option to resolve this could be adding colliders or using water without the foam animation —it works well, keeps the scene clean, and still uses only a single additional node, similar to what was done in the empty-space solution.

You have a very good point here @russell-cj . Currently in the template puzzle level the player can go off screen (camera is fixed, doesn't follow). So the proposed Void acts as a collider, which can also be solved with cliffs or with water.

[russell-cj]

Hi @manuq , @jgbourque

I’ve just pushed a new commit to this PR.

[manuq]

Hi @manuq , @jgbourque

I’ve just pushed a new commit to this PR.

Thanks! Before merging, I added a fixup commit to extend a bit the camera limits and to give the island a bit of shape, because it looked too much of a coincidence that the island had the same rectangular shape as the viewport :)

[russell-cj]

Thanks for your help, @manuq