Redesign and Implementation of Scrollable Credits System #1677

Gatorrante · 2025-11-24T08:42:24Z

This PR implements the complete redesign of the Credits screen (Credits.tscn and Credits.gd), resolving Issue #1361 by migrating the view from a static layout to a dynamic, code-managed vertical scrolling system.

credits_pr.mp4

Solution to Issue #1361

Redesigned to be Scrollable

Scene structure migrated to center around a ScrollContainer (%ScrollContainer) whose main content is a VBoxContainer (%ScrollContent).

Sectioned Structure by Discipline

%ScrollContent now houses multiple discipline-based sections
Allows easy addition and reordering of content beyond a single screen.

Gamepad/Joystick Compatibility:

The scroll logic in _process uses compound Input.get_axis("move_up", "move_down") checks, confirming full joystick and D-pad compatibility (as mapped to move_up/move_down) alongside keyboard controls for seamless navigation.

Changes in `Credits.gd`

Controlled Scroll Flow: Logic in _process manages scroll (manual via move_up/move_down and ui_up/ui_down actions, or automatic via _is_auto_scrolling).
Startup Delay (UX): await get_tree().create_timer(start_delay).timeout in start_credits_sequence() introduces a pause before enabling auto-scroll, improving UX.
Focus Management: Ensures BackButton maintains focus (grab_focus()), and mouse wheel/scroll key interactions consume the event (get_viewport().set_input_as_handled()), disabling auto-scroll.

Issue Recommendation: Open a new issue to fully review and populate content sections with all missing collaborator names.
- Script structure is complete.
- Data content is still pending.
This PR closes Issue Reimplement credits page to be vertically scrollable, with sections per discipline #1361.

Enhanced the credits screen with an animated background using AnimationPlayer and auto-scrolling functionality. Credits now scroll automatically, with speed adjustable via input, and the layout was restructured to support these features.

Major update to the credits.tscn structure, splitting credits into detailed sections for teams, contributors, and third-party components. Added new organization and engine logos (Endless, UTP, Fanny Pack Studios, Godot) and their imports. Introduced a basic shader for credits and updated UI layout for improved clarity and visual presentation.

Introduced three HSeparator nodes with custom separation and style to improve visual separation between sections in the credits scene. Adjusted PanelContainer offset for better layout spacing.

Refactored credits.gd to support both auto and manual scrolling, added configurable scroll speeds and start delay, and improved input handling for keyboard, mouse, and joystick. Updated credits.tscn to fix separator node order and adjusted footer text and layout.

Cleaned up comments and unused code in credits.gd. Updated credits.tscn to improve layout anchors and offsets, changed back button text, and added a horizontal box with directional input hints and a label to guide users on scrolling the credits.

github-actions · 2025-11-24T08:46:50Z

Play this branch at https://play.threadbare.game/branches/endlessm/Credits-Scroll.

(This launches the game from the start, not directly at the change(s) in this pull request.)

Deleted credits.gdshader and its UID file from the title menu components as they are no longer needed.

wjt · 2025-11-25T16:38:39Z

I will take a look tomorrow!

manuq

This is looking great @Gatorrante!

On logos, is a nice touch! But it will also make this pull request a bit hard to merge. Because with the exception of Godot logo (which I'm pretty confident can be used as is, as you seem to be meeting their usage guidelines) we'll need to check with each party about usage. and it would be kind to ask for them and provide their license and attribution.

On Endless logo: scenes/menus/title/components/logos/Endless.png

I think this logo needs to be for Endless Access, not for Endless Studios.

@Roddsl please confirm! And could you also attach the logo for @Gatorrante ? (check video in PR)

On Fanny Pack logo: scenes/menus/title/components/logos/fannypack_logo.png

@JuanFdS or @LauraFoglia can you please check if the usage here is fine? (check video in PR)

@Gatorrante you are also adding 2 assets for Fanny Pack, please remove the unused one.

For UTP... I don't know who should we be contacting!

scenes/menus/title/components/credits.gd

JuanFdS

The logo used in the video is all right! 👍🏾 @manuq

JuanFdS · 2025-11-27T16:05:26Z

scenes/menus/title/components/credits.tscn

Can you also add
Laura Foglia
Pablo de Haro
Tobias Romero
here
?

Indeed! I guess that the ... here were meant to complete the list. So @Gatorrante please add them all, thanks!

Yes, indeed the ... was a placeholder. :)

We have a task for adding new people #1036 that we can take within Endess; @Gatorrante for the time being please can you ensure that everyone currently credited on main is also credited in your new implementation.

scenes/menus/title/components/credits.tscn

Gatorrante · 2025-11-27T16:53:18Z

@wjt @manuq @JuanFdS Thanks for the reviews! I’ll definitely correct the requested changes and add the missing authors. Please let me know if you need anything else, no problem ;)

Gatorrante · 2025-11-27T16:55:57Z

On Endless logo: scenes/menus/title/components/logos/Endless.png

I think this logo needs to be for Endless Access, not for Endless Studios.

Where can I find the 'Endless Access' logo with a transparent background? Or is it okay if I use the version with the purple background?

wjt · 2025-11-27T17:04:36Z

Where can I find the 'Endless Access' logo with a transparent background? Or is it okay if I use the version with the purple background?

https://drive.google.com/drive/folders/15uTfJjM3-Blg6sWKdlqc_2rU0esxH7sg?usp=drive_link

scenes/menus/title/components/credits.tscn

Co-authored-by: Will Thompson <wjt@endlessaccess.org>

Replaces exported variables with private ones, adjusts manual scroll speed, and simplifies scroll/animation handling by removing redundant null checks. Adds input handling for scroll actions, ensures proper clamping of scroll position, and streamlines background animation control.

… into Credits-Scroll

Replaced 'Endless.png' with 'Endless Access Horizontal.png' and updated its import file. Removed 'fannypack_logo_white.png' and related import. Added new credits entries and a section for 5'4 Games in the credits scene.

Gatorrante · 2025-11-29T02:13:58Z

@wjt @JuanFdS
Hi there, I’ve addressed the requested changes from @manuq and I’m looking forward to your review.
For the scene, I've made this changes:

Added a new section for 5'4 Games.
Included the missing names for Fanny Pack Studios.
Temporarily disabled the UTP logo and replaced it with text until permission for its usage is decided.
Replaced the Endless Studios logo with the correct Endless Access logo.

Please let me know if this looks good to you or if you’d like any further adjustments — I’m open to making changes.
In the meantime, I’ll wait for the remaining names, or we can continue that discussion in #1036.

creditsv2.mp4

wjt

Nice work!

Gatorrante added 5 commits November 21, 2025 11:44

Add separators to credits scene layout

744185b

Introduced three HSeparator nodes with custom separation and style to improve visual separation between sections in the credits scene. Adjusted PanelContainer offset for better layout spacing.

Gatorrante added this to the Pasantes UTP Primavera 2025 milestone Nov 24, 2025

Gatorrante requested review from manuq and wjt November 24, 2025 08:42

Gatorrante self-assigned this Nov 24, 2025

Gatorrante requested a review from a team as a code owner November 24, 2025 08:42

Gatorrante added this to Threadbare Development Nov 24, 2025

Gatorrante added the Game Feel & UX label Nov 24, 2025

Gatorrante mentioned this pull request Nov 24, 2025

Reimplement credits page to be vertically scrollable, with sections per discipline #1361

Closed

Remove unused credits shader files

1a14bb9

Deleted credits.gdshader and its UID file from the title menu components as they are no longer needed.

wjt linked an issue Nov 25, 2025 that may be closed by this pull request

Reimplement credits page to be vertically scrollable, with sections per discipline #1361

Closed

manuq reviewed Nov 27, 2025

View reviewed changes

JuanFdS reviewed Nov 27, 2025

View reviewed changes

wjt reviewed Nov 27, 2025

View reviewed changes

scenes/menus/title/components/credits.tscn Outdated Show resolved Hide resolved

wjt reviewed Nov 27, 2025

View reviewed changes

scenes/menus/title/components/credits.tscn Outdated Show resolved Hide resolved

wjt reviewed Nov 28, 2025

View reviewed changes

scenes/menus/title/components/credits.tscn Show resolved Hide resolved

Gatorrante and others added 4 commits November 28, 2025 19:00

Apply suggestion from @wjt Fanny Pack names

507e10b

Co-authored-by: Will Thompson <wjt@endlessaccess.org>

Merge branch 'Credits-Scroll' of https://github.com/endlessm/threadbare…

9d80014

… into Credits-Scroll

Update credits and logos in title menu

f3c6133

Replaced 'Endless.png' with 'Endless Access Horizontal.png' and updated its import file. Removed 'fannypack_logo_white.png' and related import. Added new credits entries and a section for 5'4 Games in the credits scene.

wjt added 3 commits December 1, 2025 16:47

Remove UTP logo with unclear license

1141724

Add licenses for Endless Access, Fanny Pack, and Godot logos

39b2546

Add ´ to Tobías’s name

7e05138

wjt approved these changes Dec 1, 2025

View reviewed changes

wjt merged commit d1a5948 into main Dec 1, 2025
8 checks passed

wjt deleted the Credits-Scroll branch December 1, 2025 17:03

github-project-automation bot moved this to Done in Threadbare Development Dec 1, 2025

Redesign and Implementation of Scrollable Credits System #1677

Redesign and Implementation of Scrollable Credits System #1677

Uh oh!

Conversation

Gatorrante commented Nov 24, 2025

Solution to Issue #1361

Redesigned to be Scrollable

Sectioned Structure by Discipline

Gamepad/Joystick Compatibility:

Changes in Credits.gd

Next

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

wjt commented Nov 25, 2025

Uh oh!

manuq left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JuanFdS left a comment

Choose a reason for hiding this comment

Uh oh!

JuanFdS Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

manuq Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

wjt Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Gatorrante commented Nov 27, 2025

Uh oh!

Gatorrante commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wjt commented Nov 27, 2025

Uh oh!

Uh oh!

Gatorrante commented Nov 29, 2025

Uh oh!

wjt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Changes in `Credits.gd`

Gatorrante commented Nov 27, 2025 •

edited

Loading