credits: Fill out "Community" section#1767
Merged
Merged
Conversation
Previously not all items in the list had names attached. This is because they weren't necessary, the only thing that had to be canonicalised was the email address. However it's much easier to keep the list sorted if everyone has a name. Add names. Sort.
People do not always have a good name configured in their Git client. I populated this list by clicking through to contributors' GitHub profiles. If their full name is either shown there or can easily be found from there, I added it here. Otherwise I assume they want to be pseudonymous and do not add it.
This includes, to the best of my ability based on the Git commit history, all contributors to any file outside of scenes/quests/story_quests. The basis for not including that folder is that StoryQuests have their own credits, shown in the storybook. Some people are credited by a screen name/username because I was unable to determine another name from them based on a quick look at their GitHub profile. We will of course accept contributions to add, change, or remove names from this list if people want to be credited differently or if I have missed someone! Resolves #1036
At the time this StoryQuest was submitted, I was proposing to list mentors in the credits for each StoryQuest, which is why I asked the creators to credit Marcos here. But no other StoryQuest has a credit for the mentor. Now, we have a dedicated section in the credits for mentors. Remove Marcos' (misspelled) name.
|
Play this branch at https://play.threadbare.game/branches/endlessm/credits-community. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Dec 17, 2025
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Yes these are the names as available. We can update them upon requests.
About StoryQuest authors, I think it would be nice to have them in the credits scene under "Contributed StoryQuest" or something. But maybe in a programatic way, after we refactor the credits to have the data in resources.
| title = "El Juguete Perdido" | ||
| description = "La historia se centra en la búsqueda de Apolo, un niño curioso y valiente que ha desaparecido tras perseguir a su archienemigo, Python. El anciano Elder, preocupado por la ausencia de su nieto, encomienda al viajero la tarea de encontrarlo en las cavernas del bosque en donde asechan los goblins." | ||
| authors = Array[String](["Miguel Navarro", "Omar Mendez", "Marcos Cabana"]) | ||
| authors = Array[String](["Miguel Navarro", "Omar Mendez"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes, to the best of my ability based on the Git commit history, all
contributors to any file outside of scenes/quests/story_quests. The basis for
not including that folder is that StoryQuests have their own credits, shown in
the storybook.
Some people are credited by a screen name/username because I was unable to
determine another name from them based on a quick look at their GitHub profile.
We will of course accept contributions to add, change, or remove names from this
list if people want to be credited differently or if I have missed someone!
Resolves #1036