throwing_enemy: Fix property grouping #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is for all projectile_ properties to be grouped together
in a "Projectile" group via:
```gdscript
@export_group("Projectile", "projectile")
```
The second argument is a prefix to strip from properties in the group,
so `projectile_follows_player` becomes "Follows Player". However, per its documentation:
> The grouping will break on the first property that doesn't have a
> prefix.
In commit 117e713, `var distance` was
added right below this `@export_group`. `distance` does not have the
prefix, so the group ends.
Move the `distance` property out of the group section of the file. Move
the `projectile_scene` property into that group.
wjt
force-pushed
the
wjt/throwing-enemy-fix-property-grouping
branch
from
23c4396 to
6a04014
Compare
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/throwing-enemy-fix-property-grouping. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jan 30, 2026
Collaborator
|
Thanks @jgbourque for finding the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is for all projectile_ properties to be grouped together
in a "Projectile" group via:
The second argument is a prefix to strip from properties in the group,
so
projectile_follows_playerbecomes "Follows Player". However, per its documentation:In commit 117e713,
var distancewasadded right below this
@export_group.distancedoes not have theprefix, so the group ends.
Move the
distanceproperty out of the group section of the file. Movethe
projectile_sceneproperty into that group.