Don't set Create StoryQuest dialog as exclusive#1895
Merged
Conversation
commit 1ad24df caused Godot to crash the next time you save the project after running the StoryQuest bootstrap tool. I believe the underlying bug is the one described in this upstream issue: godotengine/godot#108003 Resolves #1894
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/don-t-set-create-storyquest-dialog-as-exclusive. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
Author
|
I'm going to merge this without review because this crash will hit everyone who creates a new StoryQuest (but at least only once). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1ad24df caused Godot to crash the next time you save the project after running the StoryQuest bootstrap tool. I believe the underlying bug is the one described in this upstream issue: godotengine/godot#108003
Resolves #1894