Conversation
The Godot editor acts as a Language Server Protocol server, and can issue diagnostics about GDScript files. Add a script that connects to this GDScript LSP server, requests diagnostics for every `.gd` file in the project (except a hardcoded list of exceptions), then outputs them. It can either launch (and terminate) its own headless instance of Godot, or connect to an existing one. When run in GitHub Actions, emit them in the [format][0] that causes them to show up in the pull request diff view against the line that triggered them, at a level corresponding to how bad Godot believes them to be. [0]: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#setting-a-notice-message Run this script during the export job (where the godot binary is available) but do not fail the export if it fails: we still want to be able to test a change, even if a function is missing a return type. Add types to Kenney spritesheet importer script. Don't check addons, script templates (which are not necessarily well-formed GDScript files), or scripts in StoryQuests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
db6877a to
0b95b74
Compare
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/ci-check-lsp-diagnostics/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Godot editor acts as a Language Server Protocol server, and can
issue diagnostics about GDScript files.
Add a script that connects to this GDScript LSP server, requests
diagnostics for every
.gdfile in the project (except a hardcoded listof exceptions), then outputs them. It can either launch (and terminate)
its own headless instance of Godot, or connect to an existing one.
When run in GitHub Actions, emit them in the format that causes
them to show up in the pull request diff view against the line that
triggered them, at a level corresponding to how bad Godot believes them
to be.
Run this script during the export job (where the godot binary is
available) but do not fail the export if it fails: we still want to be
able to test a change, even if a function is missing a return type.
Add types to Kenney spritesheet importer script. Don't check addons,
script templates (which are not necessarily well-formed GDScript files),
or scripts in StoryQuests.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com