Conversation
Every use of the shaker component uses shaker.gd directly, not Shaker.tscn. Remove the scene. Simplify the folder hierarchy.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/shaker-remove-unused-scene/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Apr 14, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Nice, I thought this was because of the global. But the global autoload is for CameraShake, which is using Shaker as a node already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shaker: Remove unused scene
Every use of the shaker component uses shaker.gd directly, not
Shaker.tscn. Remove the scene. Simplify the folder hierarchy.