Settings: Add option to disable the input HUD#2133
Merged
Conversation
I wanted this for a slightly cleaner screenshot. Rather than duplicating the code from the fullscreen toggle, make the script more generic. It now toggles a named property on the Settings singleton. Use the existing fullscreen methods as the getter/setter of a new property, and add a new property for whether the input HUD is visible. Remove a stale signal connection from the video_settings scene - the target method does not exist.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/settings-add-option-to-disable-the-input-hud/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Apr 20, 2026
| func _update_visibility() -> void: | ||
| visible = not get_tree().paused and not Transitions.is_running() and (player or sokoban_ruleset) | ||
| visible = ( | ||
| Settings.show_input_hud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings: Add option to disable the input HUD
I wanted this for a slightly cleaner screenshot.
Rather than duplicating the code from the fullscreen toggle, make the
script more generic. It now toggles a named property on the Settings
singleton. Use the existing fullscreen methods as the getter/setter of a
new property, and add a new property for whether the input HUD is
visible.
Remove a stale signal connection from the video_settings scene - the
target method does not exist.