Skip to content

Storybook: Hide navigation arrows at page boundaries#2134

Merged
wjt merged 1 commit intomainfrom
storybook-fix-navigation-arrows
Apr 21, 2026
Merged

Storybook: Hide navigation arrows at page boundaries#2134
wjt merged 1 commit intomainfrom
storybook-fix-navigation-arrows

Conversation

@dkg-0717
Copy link
Copy Markdown
Contributor

Hide the left arrow when on the first page of the storybook, and the right arrow when on the last page.

Previously, the arrows were always visible and navigating past the boundaries would wrap around to the other end of the book, which is not how books work.

Resolves #1815

Hides the left arrow on the first page and the right arrow on the
last page. Removes circular wrap-around navigation since books don't
loop from the last page back to the first.
@dkg-0717 dkg-0717 requested a review from a team as a code owner April 21, 2026 01:12
@github-actions
Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/endlessm/storybook-fix-navigation-arrows/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

Copy link
Copy Markdown
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wjt wjt merged commit c03403b into main Apr 21, 2026
6 checks passed
@wjt wjt deleted the storybook-fix-navigation-arrows branch April 21, 2026 14:25
@wjt
Copy link
Copy Markdown
Member

wjt commented Apr 21, 2026

Thanks for this fix!

You are already in the credits but if you want to adjust your name or add your GitHub username so you get linked in the credits: https://github.com/endlessm/threadbare/blob/main/scenes/menus/credits/data/endless_access.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storybook: "previous" from first page, "next" from last page

2 participants