Storybook: Hide navigation arrows at page boundaries#2134
Merged
Conversation
Hides the left arrow on the first page and the right arrow on the last page. Removes circular wrap-around navigation since books don't loop from the last page back to the first.
|
Play this branch at https://play.threadbare.game/branches/endlessm/storybook-fix-navigation-arrows/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
|
Thanks for this fix! You are already in the credits but if you want to adjust your name or add your GitHub username so you get linked in the credits: https://github.com/endlessm/threadbare/blob/main/scenes/menus/credits/data/endless_access.csv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the left arrow when on the first page of the storybook, and the right arrow when on the last page.
Previously, the arrows were always visible and navigating past the boundaries would wrap around to the other end of the book, which is not how books work.
Resolves #1815