checkpoint: Make player spawn in front, not behind#2153
Merged
Conversation
The player spawns at the position of the SpawnPoint inside this node, previously identical to the Checkpoint node itself. As a result, on respawn the player and the checkpoint have the same y-sort level, and their position in the scene tree determines which one is displayed in front of the other. The player is earlier in the scene tree in most scenes, so the later-in-tree checkpoint wins. Move the SpawnPoint one pixel downwards, so that the player "wins". Also offset the sprite a little more. This breaks our normal model where the origin of the scene is aligned with the middle of the sprite's shadow. However the witch is a bit of a strange shape - the yarn is way below it - and I think that sorting behind the witch as soon as you walk above the yarn (as with this change) looks better. Resolves #1332
Member
Author
|
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/checkpoint-make-player-spawn-in-front-not-behind/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
May 1, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
The one pixel solution! I agree on moving the sprite too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The player spawns at the position of the SpawnPoint inside this node,
previously identical to the Checkpoint node itself.
As a result, on respawn the player and the checkpoint have the same
y-sort level, and their position in the scene tree determines which one
is displayed in front of the other. The player is earlier in the scene
tree in most scenes, so the later-in-tree checkpoint wins.
Move the SpawnPoint one pixel downwards, so that the player "wins".
Also offset the sprite a little more. This breaks our normal model where
the origin of the scene is aligned with the middle of the sprite's
shadow. However the witch is a bit of a strange shape - the yarn is way
below it - and I think that sorting behind the witch as soon as you walk
above the yarn (as with this change) looks better.
Resolves #1332