Fit logo animation sprite sheet under 4096×4096#2196
Merged
Conversation
Previously it was a single-row 18×1 sprite sheet, 13824x768, which did not display correctly on mobile devices where textures must be at most 4096×4096. Reëxport it with three rows of 6 frames. Update the SpriteFrames resource. Resolves #2195
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/fit-logo-animation-sprite-sheet-under-4096-4096/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
Author
|
manuq
approved these changes
May 15, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Nice! Can we document this limitation somewhere in the wiki's developers section? Like: "Textures width shouldn't be larger than ...".
Member
Author
|
It's documented on https://github.com/endlessm/threadbare/wiki/Visual-Style-Guide |
Collaborator
Oh yes I remember now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was a single-row 18×1 sprite sheet, 13824x768, which did
not display correctly on mobile devices where textures must be at most
4096×4096.
Reëxport it with three rows of 6 frames. Update the SpriteFrames
resource.
Resolves #2195