Skip to content

pre-commit: Check for images exceeding 4096×4096#2207

Merged
manuq merged 1 commit into
mainfrom
wjt/pre-commit-check-for-images-exceeding-4096-4096
May 18, 2026
Merged

pre-commit: Check for images exceeding 4096×4096#2207
manuq merged 1 commit into
mainfrom
wjt/pre-commit-check-for-images-exceeding-4096-4096

Conversation

@wjt
Copy link
Copy Markdown
Member

@wjt wjt commented May 16, 2026

As documented in
https://github.com/endlessm/threadbare/wiki/Visual-Style-Guide#image-file-format
this is a limitation of mobile GPUs.

Check all PNGs, JPEGs and WebPs against this limit using a small Python
program using Pillow.

Update the GitHub Actions workflow to check out objects from LFS.

@wjt
Copy link
Copy Markdown
Member Author

wjt commented May 16, 2026

https://github.com/endlessm/threadbare/actions/runs/25969999412/job/76340189768 failed successfully:

check image dimensions...................................................Failed
- hook id: check-image-size
- exit code: 1

assets/first_party/wildlife/butterfly/butterfly_air_loop_red.png: 16896x192 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_air_loop_blue.png: 16896x192 exceeds 4096x4096
scenes/menus/title/components/logos/fannypack_logo.png: 4184x1205 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_flower_loop_2_pink.png: 7040x128 exceeds 4096x4096
scenes/menus/storybook/Textures/book_turn_right.png: 9990x720 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_flower_loop_2_green.png: 7040x128 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_air_loop_green.png: 16896x192 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_flower_loop_2_red.png: 7040x128 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_flower_loop_2_blue.png: 7040x128 exceeds 4096x4096
assets/first_party/logo/threadbare-logo-animation.png: 4608x2304 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_air_loop_pink.png: 16896x192 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_air_loop_orange.png: 16896x192 exceeds 4096x4096
scenes/menus/storybook/Textures/book_turn_left.png: 9990x720 exceeds 4096x4096
assets/first_party/wildlife/butterfly/butterfly_flower_loop_2_orange.png: 7040x128 exceeds 4096x4096

#2206 will address these.

@wjt wjt linked an issue May 16, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/endlessm/wjt/pre-commit-check-for-images-exceeding-4096-4096/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt wjt changed the title pre-commit: Check for images exceeding 4096×4096 [2/2] pre-commit: Check for images exceeding 4096×4096 May 18, 2026
@wjt wjt force-pushed the wjt/pre-commit-check-for-images-exceeding-4096-4096 branch from ad04fec to 17199f2 Compare May 18, 2026 08:59
@wjt wjt changed the base branch from main to wjt/fix-all-images-that-exceed-4096-4096 May 18, 2026 08:59
@wjt
Copy link
Copy Markdown
Member Author

wjt commented May 18, 2026

I merged #2156 and restacked this on #2206 which should make the check green.

@wjt wjt force-pushed the wjt/fix-all-images-that-exceed-4096-4096 branch from 1f1cd25 to d36fa06 Compare May 18, 2026 09:08
@wjt wjt force-pushed the wjt/pre-commit-check-for-images-exceeding-4096-4096 branch from 17199f2 to 3ac5b09 Compare May 18, 2026 09:13
@wjt wjt force-pushed the wjt/fix-all-images-that-exceed-4096-4096 branch from d36fa06 to cd68d61 Compare May 18, 2026 09:21
@wjt wjt force-pushed the wjt/pre-commit-check-for-images-exceeding-4096-4096 branch from 3ac5b09 to 8be31df Compare May 18, 2026 09:21
Base automatically changed from wjt/fix-all-images-that-exceed-4096-4096 to main May 18, 2026 13:43
As documented in
https://github.com/endlessm/threadbare/wiki/Visual-Style-Guide#image-file-format
this is a limitation of mobile GPUs.

Check all PNGs, JPEGs and WebPs against this limit using a small Python
program using Pillow.

Update the GitHub Actions workflow to check out objects from LFS.
@wjt wjt force-pushed the wjt/pre-commit-check-for-images-exceeding-4096-4096 branch from 8be31df to 7da56a0 Compare May 18, 2026 13:51
@wjt wjt changed the title [2/2] pre-commit: Check for images exceeding 4096×4096 [1/1] pre-commit: Check for images exceeding 4096×4096 May 18, 2026
@wjt wjt changed the title [1/1] pre-commit: Check for images exceeding 4096×4096 pre-commit: Check for images exceeding 4096×4096 May 18, 2026
@wjt wjt marked this pull request as ready for review May 18, 2026 13:53
@wjt wjt requested a review from a team as a code owner May 18, 2026 13:53
@manuq manuq merged commit 4dc60d4 into main May 18, 2026
7 checks passed
@manuq manuq deleted the wjt/pre-commit-check-for-images-exceeding-4096-4096 branch May 18, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

butterfly_air_loop_*.png textures too large for Godot

2 participants