Skip to content

Player: Stop player particle system running on player defeat#2370

Merged
manuq merged 2 commits into
endlessm:mainfrom
Litraxx:stop-player-particle-system-on-defeat
Jun 12, 2026
Merged

Player: Stop player particle system running on player defeat#2370
manuq merged 2 commits into
endlessm:mainfrom
Litraxx:stop-player-particle-system-on-defeat

Conversation

@Litraxx

@Litraxx Litraxx commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The player's particle system now stops emitting when the player is defeated.

Resolves #2260

@Litraxx Litraxx requested a review from a team as a code owner June 12, 2026 19:47
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Test build no longer available.

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it and works as expected.

recording.webm

Thanks for your contribution, @Litraxx !

Comment thread scenes/game_elements/characters/player/components/player.gd Outdated
@manuq manuq merged commit c120332 into endlessm:main Jun 12, 2026
7 checks passed
@wjt

wjt commented Jun 15, 2026

Copy link
Copy Markdown
Member

Thanks for this contribution, @Litraxx! To add yourself to the game's credits you can open a PR to add a new row to this CSV:

https://github.com/endlessm/threadbare/blob/main/scenes/menus/credits/data/community.csv

Put yourself above the first row that has "Mentors" within.

I'm also curious to know how you found Threadbare and decided to contribute. :)

@Litraxx

Litraxx commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@wjt I saw the talk you held at GodotCon 2026 and though this is a great initiative. As to why I decided to contribute, starting your own game project always seemed very daunting to me. Having an already working game where you can add smaller parts is a lot more approachable to me personally and it also makes learning easier.

@wjt

wjt commented Jun 15, 2026

Copy link
Copy Markdown
Member

That's great! You're also welcome to join us on our Discord (link in the README).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running dust particles continue while player falls into the Void

3 participants