Skip to content

Add a French localization#2408

Merged
wjt merged 6 commits into
endlessm:mainfrom
Max6mm:main
Jun 22, 2026
Merged

Add a French localization#2408
wjt merged 6 commits into
endlessm:mainfrom
Max6mm:main

Conversation

@Max6mm

@Max6mm Max6mm commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Add a French localization for Menus

@Max6mm Max6mm requested a review from a team as a code owner June 19, 2026 14:42
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Test build no longer available.

manuq
manuq previously requested changes Jun 19, 2026

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Max6mm thanks for your contribution!

Strange, using the Language Settings menu and pressing the Français option doesn't update the user interface:

Image

@Max6mm

Max6mm commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@Max6mm thanks for your contribution!

Strange, using the Language Settings menu and pressing the Français option doesn't update the user interface:

I forgot to add the signal for this button. It should works now

@wjt wjt requested a review from manuq June 22, 2026 09:57

@wjt wjt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci bien ! Based on my very limited French knowledge, this looks good to me. I pushed an extra patch to fix a coding style check.

@Max6mm if you would like to be listed in the game credits, please open a PR to add yourself to https://github.com/endlessm/threadbare/blob/main/scenes/menus/credits/data/community.csv - just above the first row that ends with "Mentors". You can provide one or both of your name (which may be a pseudonym if you prefer) and your GitHub username.

I am curious how you found Threadbare and decided to submit this translation.

Comment thread locale/fr.po
@wjt wjt dismissed manuq’s stale review June 22, 2026 10:00

Feedback was addressed - the button works now.

@wjt wjt merged commit aeebfc8 into endlessm:main Jun 22, 2026
7 checks passed
@Max6mm

Max6mm commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Merci bien ! Based on my very limited French knowledge, this looks good to me. I pushed an extra patch to fix a coding style check.

@Max6mm if you would like to be listed in the game credits, please open a PR to add yourself to https://github.com/endlessm/threadbare/blob/main/scenes/menus/credits/data/community.csv - just above the first row that ends with "Mentors". You can provide one or both of your name (which may be a pseudonym if you prefer) and your GitHub username.

I am curious how you found Threadbare and decided to submit this translation.

I just found the game on flathub. Try it and saw there was english and spanish language, so i came here to check if I was able to add french translation.
Are you interested in translation for the lorequests ? I could create a .csv file to translate them in french, and also make it ready for someone who would want to translate them in spanish.

@manuq

manuq commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

I just found the game on flathub. Try it and saw there was english and spanish language, so i came here to check if I was able to add french translation. Are you interested in translation for the lorequests ? I could create a .csv file to translate them in french, and also make it ready for someone who would want to translate them in spanish.

Good to know that the Flathub build is worth it! Thanks for your contribution. As per translating the lore quests, they are going to change a lot so is too early for translating them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants