Rename music puzzle to sequence puzzle #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "bonfire" nature of this sign is now specific to the LoreQuest music puzzle. Rename the scene to a generic name, updating references elsewhere. #526
These are no longer fire-specific.
The sign is no longer necessarily a bonfire, so it doesn't make sense to talk about "igniting" it.
Previouly this component was buried inside the first lorequest. Rehome it to game_elements/props, which matches comparable props like the ink jars in the combat minigame. #526
This is no longer necessarily a rock, nor musical, but a generic object that can be kicked and may or may not make a musical sound when the player does so. Rename the scene & class; adjust its API to reflect its new generic nature. Rehouse it from a xylophone directory in the lorequest puzzle into the components tree. Move the rock sprite frames up one level of the hierarchy, to the lorequest puzzle's components directory. #526
This is no longer music-specific. Rename MusicPuzzle to SequencePuzzle, and move it plus its SequencePuzzleStep sub-component to the game_logic directory. Fixes #526
It's no longer necessarily musical. Rename the scene, nodes within it, its directory, and relevant assets. Update the dialogue. #526
Collaborator
I wonder if we really need this. Asking over Discord. |
manuq
approved these changes
May 15, 2025
| var hint_levels: Dictionary = {} | ||
|
|
||
| var _rocks: Array[MusicalRock] | ||
| var _objects: Array[SequencePuzzleObject] |
Collaborator
There was a problem hiding this comment.
Maybe "object" is too generic? Anyways it works.
cassidyjames
pushed a commit
to cassidyjames/threadbare
that referenced
this pull request
Jun 17, 2025
…sequence-puzzle Rename music puzzle to sequence puzzle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The music puzzle logic and its element have now been made generic enough to be used for various different sequence puzzles. So we can now rename all the scenes, scripts, and some lingering music and rock references in the API, and move the files out of the LoreQuest into generic directories.
Fixes #526
One remaining piece is that I can make the musician a generic NPC but I'll do that as a follow-up.