-
Notifications
You must be signed in to change notification settings - Fork 79
DO NOT MERGE flip non trapping shim default #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
erights
wants to merge
13
commits into
markm-use-no-trapping-shim
Choose a base branch
from
markm-flip-non-trapping-shim-default
base: markm-use-no-trapping-shim
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DO NOT MERGE flip non trapping shim default #2699
erights
wants to merge
13
commits into
markm-use-no-trapping-shim
from
markm-flip-non-trapping-shim-default
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0098db1 to
a11fc2e
Compare
eb96f7f to
bd79cff
Compare
a11fc2e to
e40dcb3
Compare
bd79cff to
19e38a7
Compare
10 tasks
e40dcb3 to
8173b85
Compare
19e38a7 to
83de018
Compare
8173b85 to
8af0295
Compare
83de018 to
700dccf
Compare
8af0295 to
358cc91
Compare
700dccf to
b6e8131
Compare
c160527 to
bfb8acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #2675
Closes: #XXXX
Refs: #XXXX
Description
Flips the non-trapping shim to default
'enabled', requiring opt-out to be explicit.This is not intended for production, but rather only to test in CI that everything else is compat with the opted in setting.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations