Skip to content

Update endpoints libs#7

Merged
julienrf merged 1 commit intoendpoints4s:mainfrom
OlegYch:update-endpoints
Oct 17, 2024
Merged

Update endpoints libs#7
julienrf merged 1 commit intoendpoints4s:mainfrom
OlegYch:update-endpoints

Conversation

@OlegYch
Copy link
Copy Markdown
Collaborator

@OlegYch OlegYch commented Oct 16, 2024

No description provided.

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 16, 2024

@julienrf can you please release

@julienrf julienrf merged commit ab42da1 into endpoints4s:main Oct 17, 2024
@julienrf
Copy link
Copy Markdown
Member

@OlegYch Thank you for the maintenance work! I think you should have enough rights to cut the release here: https://github.com/endpoints4s/play/releases (I guess the version should be 7.0.0 since we bumped the openapi module). Could you please confirm?

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 17, 2024

@julienrf yep it seems to have worked

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 17, 2024

@julienrf actually it looks like it failed

> ci-release
No access to secret variables, doing nothing

@julienrf
Copy link
Copy Markdown
Member

I am not sure what’s going wrong :-/

This message is printed if the sbt-ci-release plugin estimates that the execution environment is not “secure”. In our case, this condition should be true:

https://github.com/sbt/sbt-ci-release/blob/4415c89701c38c96711138d5e115a0fd5985f2ef/plugin/src/main/scala/com/geirsson/CiReleasePlugin.scala#L32

Could you please investigate the issue? Feel free to re-create a GPG key pair if necessary…

Also FYI I removed your last commit that resets the compatibility intention. We can re-apply it after the release works.

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 18, 2024

@julienrf i don't have access to repository secrets

@julienrf
Copy link
Copy Markdown
Member

Could you please retry now?

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 18, 2024

@julienrf the problem was with passing env vars to sbt, i fixed it
but i messed up the secrets (although they might have been messed up before that) so someone with permission to publish to endpoints4s on central will need to update SONATYPE (and possibly PGP) secrets

@julienrf
Copy link
Copy Markdown
Member

Thank you for fixing those issues! I’ve reset the Sonatype credentials and re-launched the job…

@OlegYch
Copy link
Copy Markdown
Collaborator Author

OlegYch commented Oct 18, 2024

@julienrf cheers, it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants