Skip to content

Fix shop: Surge refresh should not resurrect purchased card offers#135

Merged
endrawes0 merged 2 commits intomainfrom
feature/fix-shop-surge-replace-card
Jan 9, 2026
Merged

Fix shop: Surge refresh should not resurrect purchased card offers#135
endrawes0 merged 2 commits intomainfrom
feature/fix-shop-surge-replace-card

Conversation

@endrawes0
Copy link
Owner

@endrawes0 endrawes0 commented Jan 9, 2026

Fixes #129.

Root cause:

  • Purchasing a shop card only removed the UI button; the card id stayed in ShopManager.card_offers.
  • Buying Surge triggers a shop UI refresh, which rebuilds from card_offers, so previously purchased cards can reappear.

Change:

  • On card purchase, remove that card id from ShopManager.card_offers so future refreshes reflect current offers.

Test plan:

  • Enter shop, buy any card, then buy Surge.
  • Confirm the purchased card does not reappear in the shop offers.

Closes #129.

@endrawes0 endrawes0 marked this pull request as ready for review January 9, 2026 14:09
@endrawes0 endrawes0 merged commit 9728a2f into main Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Surge replaced a card in the shop

1 participant