Skip to content
This repository was archived by the owner on Mar 17, 2019. It is now read-only.

Motion Presets switch carousel to appropriate sensor#49

Merged
bdonald25 merged 3 commits intoengaging-computing:masterfrom
bdonald25:presetFix
Nov 20, 2014
Merged

Motion Presets switch carousel to appropriate sensor#49
bdonald25 merged 3 commits intoengaging-computing:masterfrom
bdonald25:presetFix

Conversation

@bdonald25
Copy link
Copy Markdown
Contributor

GPS preset switches carousel to lat/lon
Acceleration preset switches it to show accel values
@stowellm

@bdonald25 bdonald25 changed the title Motion Presets switches carousel to appropriate field Motion Presets switch carousel to appropriate field Nov 7, 2014
@bdonald25 bdonald25 changed the title Motion Presets switch carousel to appropriate field Motion Presets switch carousel to appropriate sensor Nov 7, 2014
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious as to what "0" (and later in the code "1") values have to do with the FIELD key. If it is defined as some preset, should it be a constant?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the position of the carousel. 0 is the first position which is acceleration, 1 is the second position which is lat and lon.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - definitely want to make these constants then.

bdonald25 added a commit that referenced this pull request Nov 20, 2014
Motion Presets switch carousel to appropriate sensor
@bdonald25 bdonald25 merged commit 4ae18df into engaging-computing:master Nov 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants