Reorder the MADCTL bits to match the datasheet#3
Merged
Conversation
When none of the MV/X/Y bits is set, ie. no transformation, the top-left of the display is such that the ribbon cable of the LCD module enters the top edge, with column numbers increasing from left-to-right, and row numbers increasing upon moving further down the panel, away from the ribbon cable. This PR corrects the declaration of the MV, MX and MY bits and updates the orientation settings accordingly so client code using the API should be unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When none of the MV/X/Y bits is set, ie. no transformation, the top-left of the display is such that the ribbon cable of the LCD module enters the top edge, with column numbers increasing from left-to-right, and row numbers increasing upon moving further down the panel, away from the ribbon cable.
This PR corrects the declaration of the MV, MX and MY bits and updates the orientation settings accordingly so client code using the API should be unaffected.