Skip to content

Add functions to detect and apply offiset on using displays with a GM[2:0] misconfiguration#5

Merged
engdoreis merged 12 commits into
mainfrom
develop
Apr 17, 2025
Merged

Add functions to detect and apply offiset on using displays with a GM[2:0] misconfiguration#5
engdoreis merged 12 commits into
mainfrom
develop

Conversation

@engdoreis
Copy link
Copy Markdown
Owner

@engdoreis engdoreis commented Apr 11, 2025

For some cheap displays, the controller resolution may be configured to 132x162 pixels, that exceeds the panel's of 128x160 pixels.

This PR changes the driver API to allow the application to deal with these displays.

Copy link
Copy Markdown

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments from my end.

Comment thread core/lcd_base.h Outdated
Comment thread st7735/lcd_st7735.c
Comment thread st7735/lcd_st7735.c Outdated
Comment thread core/lcd_base.h Outdated
Comment thread st7735/lcd_st7735.h Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread st7735/lcd_st7735.c Outdated
Comment thread st7735/lcd_st7735.c Outdated
Comment thread core/lcd_base.h
Comment thread st7735/lcd_st7735.c
Comment thread st7735/lcd_st7735.c Outdated
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
@engdoreis engdoreis force-pushed the develop branch 6 times, most recently from 09deed8 to 14acbc9 Compare April 15, 2025 10:49
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
engdoreis and others added 8 commits April 17, 2025 09:50
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Co-authored-by: Elliot Baptist <elliot.baptist@lowrisc.org>
@engdoreis engdoreis merged commit 8de2c6c into main Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants