Implement Promise.allKeyed, Promise.allSettledKeyed.

[ajvincent]

Smoketest on npm run inspector:

const blocking = Promise.withResolvers();
async function getShape() {
  await blocking.promise;
  return "cube";
}

async function getColor() {
  await blocking.promise;
  throw new Error("no color available");
}

async function getMass() {
  await blocking.promise;
  return 4000; // kg
}

const promiseDictionary = {
  shape: getShape(),
  color: getColor(),
  mass: getMass(),
};

const dictionary = Promise.allSettledKeyed(promiseDictionary);
blocking.resolve();

try {
  console.log(await dictionary);
} catch (ex) {
  console.log("caught exception");
  console.error(ex);
}

I was getting reasonable results when I tweaked this for all promises resolving, and for allSettled instead of allSettledKeyed.

As directed, this is behind a feature flag. Nice that npm run inspector picked up on it automatically.

[Jack-Works]

Hi! I would prefer to remove spec steps if they're very straitforward.

For example I will keep comments like this:

// 1. If an implementation-defined debugging facility is available and enabled, then

  // 1. If StringToCodePoints(text) is not a valid JSON text as specified in ECMA-404, throw a SyntaxError exception.
  Q(JSONValidator.validate(text));

[ajvincent]

I know... I have this bad habit of being robotic, trying to capture everything as written, when it comes to the specs.

[Jack-Works]

Hi, I just pushed a big commit, if you have difficulties with merging plz let me know

[ajvincent]

Hi, I just pushed a big commit, if you have difficulties with merging plz let me know

npm run inspector lost the feature flags.

Uncaught TypeError: Cannot destructure property 'Agent' of 'self.@engine262/engine262' as it is undefined.
at worker.js:9:3

[Jack-Works]

Hi, I just pushed a big commit, if you have difficulties with merging plz let me know

npm run inspector lost the feature flags.

Uncaught TypeError: Cannot destructure property 'Agent' of 'self.@engine262/engine262' as it is undefined. at worker.js:9:3

Hi I cannot reproduce this on my side, have you update the submodule (website folder)?

[Jack-Works]

This looks like a spec bug. Spec capture should not (at least no precedence, as I can recall) capture a variable (only constants).

You can raise an issue in the proposal.

[Jack-Works]

wait for tc39/proposal-await-dictionary#29

[Jack-Works]

Hi! Please revert your changes on website and test262 submodule (unless it is necessary).

[ajvincent]

Hi! Please revert your changes on website and test262 submodule (unless it is necessary).

This was an unintended change. I'm trying to find the time to do the necessary cleanup.