refactor(vulkan): Moving vk::physical_device enumeration to vk::instance#71
Merged
Conversation
… reports for specific properties for the physical device
… constructor reasoning
SpinnerX
commented
May 22, 2026
Member
Author
SpinnerX
left a comment
SpinnerX
left a comment
There was a problem hiding this comment.
Ready to being merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Overview
This PR resolves #60.
Changelogs
vk::instance.vk::physical_devicepropertiesto queryVkPhysicalDeviceProperties.queue_family_propertiesqueries contiguous array of VkQueueFamilyProperties.is_present_supported(VkSurfaceKHR)queries if the given surface has presentation supported.vk::swapchainremovingstd::printlnstatement.