j nix package#447
Merged
Merged
Conversation
scpchicken
force-pushed
the
nix-cool
branch
3 times, most recently
from
16379f0 to
9c761bf
Compare
Contributor
Author
|
does someone know how to make more tests? |
HexF
reviewed
Feb 24, 2022
| stdin = ""; | ||
| packages = []; | ||
| main = "test.ijs"; | ||
| }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| }) | |
| }) | |
| (piston.mkTest { | |
| files = { | |
| "test.ijs" = '' | |
| echo'OK' | |
| ''; | |
| }; | |
| args = []; | |
| stdin = ""; | |
| packages = []; | |
| main = "test.ijs"; | |
| }) |
You can add more tests like this
HexF
approved these changes
Feb 25, 2022
| # | ||
| # No shebang needs to be added to this - that is done automatically. | ||
| # compile = '' | ||
| # ${pkg}/bin/j --compile "$@" |
Collaborator
There was a problem hiding this comment.
If compiling is supported, I would rather we use it.
Comment on lines
+18
to
+21
| # Put extensions in here, and other common names | ||
| # Example: | ||
| # "js" | ||
| # "node-javascript" |
Collaborator
There was a problem hiding this comment.
All these comments can be removed, as can all the others from the scaffold.
HexF
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok i think chose the right branch this time