Skip to content

handle stdout and stderr limits properly#643

Merged
HexF merged 2 commits intoengineer-man:masterfrom
AbsoluteZero000:output-limits
Jan 26, 2024
Merged

handle stdout and stderr limits properly#643
HexF merged 2 commits intoengineer-man:masterfrom
AbsoluteZero000:output-limits

Conversation

@AbsoluteZero000
Copy link
Copy Markdown
Contributor

the checking of the length of the stdout and stderr was checking on the stdout and stderr before the addition of the data characters so it passes any length of characters as long as passing the limit is in the same buffer.

basically

{
  "language": "python3",
  "version": "*",
  "files": [
    {
      "name": "test",
      "content": "print('h'*5000)"
    }
    
  ],
  "stdin": "2"
}

this passes when it shouldn't

Co-authored-by: Omar Brikaa <brikaaomar@gmail.com>
Comment thread docker-compose.dev.yaml
@AbsoluteZero000 AbsoluteZero000 requested a review from HexF January 26, 2024 06:00
@HexF HexF merged commit 647bc3a into engineer-man:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants