Skip to content

Feedback for Ahmed #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feedback for Ahmed #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions Yousif/example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="author" content="Ahmed Yousif">
<title>Title of page</title>
</head>
<body>
<!--
OVERALL FEEDBACK

I think you'll agree that your project is kinda sparse and messy right now, and I imagine it's hard to know where to revise, add things, subtract, change, etc. I highly recommend dedicating this week to starting it over from scratch. It sounds daunting, but you have ideas to draw upon, so you're not starting from scratch there.

Also, be sure to work on those images.

Be sure to use the resources from the readings + the handouts, such as the HTML Reference Guide. I think that'll help you develop your structure.

Furthermore, be sure to clean up your project. For example, your 'Assets' folder needs to be all lowercase. Your images folder should be inside of the assets folder, and you have a 'web1.html' file.

Remember that we're focusing on big structure/landmarks, so most pages will include the following example structure with varied subparts within them of course. I hope this helps you take the time this week to get caught up before the midterm and especially our CSS unit. You'll fall behind quite a bit, if you're not hip to some of these HTML concepts and techniques.
-->
<a href =”#main” class=”skip-to-link”>Skip to content<a/>
<header>
<h1>Title of Page</h1>
<!-- IMG? -->
</header>
<nav>
<ul>
<li><a href="">Page 1</a></li>
<li><a href="">Page 2</a></li>
<li><a href="">Page 3</a></li>
</ul>
</nav>
<!-- The main content/sturcture will vary for you and everyone, so take this example with a grain of salt. -->
<main id="main">
<h2></h2>
<p></p>
<section>
<h3></h3>
<p></p>
<p></p>
</section>
<section>
<h3></h3>
<p></p>
<p></p>
</section>
<section>
<h3></h3>
<p></p>
<p></p>
</section>
</main>
<footer>
<p>Copyright info</p>
</footer>
</body>
</html>