fix: hide stream latency on clips #123

igorovh · 2025-12-29T02:01:00Z

No description provided.

gemini-code-assist · 2025-12-29T02:01:12Z

Summary of Changes

Hello @igorovh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on two areas: enhancing the build and packaging script for better code quality and maintainability, and refining the user interface by ensuring that stream latency information does not appear on chat clips, which improves the overall viewing experience.

Highlights

Build Script Refactor: The pack.ts script has been significantly refactored to improve readability and maintainability, including the use of modern async file system APIs.
Stream Latency on Clips: The stream latency display is now correctly hidden on chat clips to prevent UI clutter and improve user experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the packaging script and fixes an issue with stream latency display on clips. The script refactoring improves code clarity but introduces a minor regression in handling process exit codes. The latency fix has a potential logic bug where it might prematurely exit a loop. My review includes suggestions to address these two points.

src/platforms/kick/modules/stream-latency/stream-latency.module.tsx

gemini-code-assist · 2025-12-29T02:02:17Z

scripts/pack.ts

+if ((await buildProc.exited) !== 0) {
+	console.error("Build failed");
+	process.exit(1);
 }


This refactoring has introduced a small regression. By hardcoding the exit code to 1, we lose the specific exit code from the build process, which can be useful for debugging. The previous implementation was better in this regard as it propagated the actual exit code. I'd suggest reverting to a similar pattern to preserve this information.

const buildStatus = await buildProc.exited; if (buildStatus !== 0) { console.error("Build failed"); process.exit(buildStatus); }

Copilot

Pull request overview

This PR aims to hide the stream latency indicator when viewing clips on the Kick platform, while also refactoring the build script for improved code quality.

Added check to skip rendering stream latency component on chat rooms with the --chat-clip class
Refactored the pack.ts script with clearer naming and more modern async patterns
Simplified the build process flow and improved code readability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`src/platforms/kick/modules/stream-latency/stream-latency.module.tsx`	Added conditional check to skip stream latency display on clip chat rooms
`scripts/pack.ts`	Refactored archive creation logic with improved naming, modernized async patterns, and restructured code flow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-29T02:02:45Z

src/platforms/kick/modules/stream-latency/stream-latency.module.tsx

 		this.updateInterval = setInterval(() => this.updateLatency(), 1000);

 		for (const chatRoom of elements) {
+			if (chatRoom.className.includes("--chat-clip")) return;


Using 'return' here will exit the entire function when the first chat room has the '--chat-clip' class, preventing processing of subsequent chat rooms in the loop. This should use 'continue' instead to skip only the current iteration and process remaining chat rooms.

Suggested change

if (chatRoom.className.includes("--chat-clip")) return;

if (chatRoom.className.includes("--chat-clip")) continue;

Copilot · 2025-12-29T02:02:45Z

scripts/pack.ts

+await archiveDirectory("dist", buildZipPath);
+console.log(`Created ${buildZipPath}`);
+
+const sourceZipPath = path.join("dist", `source-${version}.zip`);
+await archiveDirectory(".", sourceZipPath, IGNORED_DIRS);


The build zip file created on line 47 will be included in the source zip created on line 51. The original implementation excluded the build zip file from the source archive. This means the source zip will now contain the build zip, which is likely unintended and will significantly increase the source archive size.

scripts/pack.ts

…e.tsx Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

openhands-ai · 2025-12-29T02:06:43Z

Looks like there are a few issues preventing this PR from being merged!

GitHub Actions are failing:
- Build

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #123 at branch `fix/hide-stream-latency-on-clips`

Feel free to include any additional details that might help me get this PR into a better state.

_{^{You can manage your notification settings}}

igorovh added 2 commits December 29, 2025 02:51

update pack script

4ed983f

fix: hide stream latency on clips

1d7e6ad

Copilot AI review requested due to automatic review settings December 29, 2025 02:01

Copilot started reviewing on behalf of igorovh December 29, 2025 02:01 View session

igorovh changed the title ~~Fix/hide stream latency on clips~~ fix: hide stream latency on clips Dec 29, 2025

gemini-code-assist bot reviewed Dec 29, 2025

View reviewed changes

Copilot AI reviewed Dec 29, 2025

View reviewed changes

igorovh and others added 2 commits December 29, 2025 03:05

Update src/platforms/kick/modules/stream-latency/stream-latency.modul…

18df907

…e.tsx Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update scripts/pack.ts

4505da0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix lint

ed1b2b3

igorovh merged commit ceba6bc into master Dec 29, 2025
1 check passed

igorovh deleted the fix/hide-stream-latency-on-clips branch December 29, 2025 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: hide stream latency on clips #123

fix: hide stream latency on clips #123

Uh oh!

igorovh commented Dec 29, 2025

Uh oh!

gemini-code-assist bot commented Dec 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Dec 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 29, 2025

Uh oh!

Copilot AI Dec 29, 2025

Uh oh!

Uh oh!

openhands-ai bot commented Dec 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (chatRoom.className.includes("--chat-clip")) return;
	if (chatRoom.className.includes("--chat-clip")) continue;

fix: hide stream latency on clips #123

fix: hide stream latency on clips #123

Uh oh!

Conversation

igorovh commented Dec 29, 2025

Uh oh!

gemini-code-assist bot commented Dec 29, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openhands-ai bot commented Dec 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants