bugfix: stream latency reducer does not allow to change palyrate on vods

[igorovh]

changing the logic, to faster checking if it is a live, and also bypassing the hook when it is VOD (checking the /vidoes/)

fixes #153

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the stream latency reducer prevented users from changing the playback rate on Twitch VODs. It introduces logic to bypass the reducer's interference for VOD content and optimizes the live stream detection process to improve efficiency by performing the check earlier in the execution flow.

Highlights

• VOD Playback Rate Fix: The stream latency reducer no longer interferes with playback rate changes on Twitch VODs by explicitly allowing rate changes when the URL indicates a video (e.g., '/videos/').
• Optimized Live Check: The check for whether a stream is live has been moved to an earlier point in the run method, preventing unnecessary calls to getPlaybackRateStatus if the stream is not live.
• Refactored Playback Status Logic: The getPlaybackRateStatus method no longer returns 'invalid' if the stream is not live, allowing its logic to proceed for non-live content like VODs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/platforms/twitch/modules/stream-latency-reducer/stream-latency-reducer.module.tsx
  • Moved the isLive() check to an earlier point within the run method's interval callback.
  • Modified playbackRateSetHook to allow playback rate changes for VODs by checking the window.location.href.
  • Simplified a boolean comparison from === false to ! in changePlaybackSpeed.
  • Removed the isLive() check from getPlaybackRateStatus to prevent it from returning 'invalid' for non-live content.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the issue of not being able to change the playback rate on VODs by adjusting the logic in the stream latency reducer. The changes introduce a check for VODs to bypass the playback rate lock and also refactor the live stream check for better performance. My feedback includes a suggestion to improve the function signature of the playback rate hook.

[Copilot]

Pull request overview

This PR adjusts the Twitch stream latency reducer to avoid interfering with playback rate changes on VOD pages, and shifts the “is this live?” gating to an earlier point in the polling loop.

Changes:

• Skip the periodic latency-reducer logic when the current content is not live.
• Allow the playbackRate setter hook to pass through on VOD URLs (/videos/).
• Change FFZ “allow catch-up” handling logic in changePlaybackSpeed.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.