fix(deps): require light-runner 0.16.2 for the detached-extract fix#13
Merged
Conversation
light-run always calls light-runner with detached + extract. Before 0.16.2 a detached run that extracted artifacts never finalized (the seeder hung waiting on a hijacked attach stream that volume-bound containers do not reliably close on Docker Desktop / Windows), so the run stayed `running` forever and every caller polling it looped indefinitely. 0.16.2 finalizes via inspect() polling. - light-runner ^0.16.1 -> ^0.16.2 (hard floor: the fix is required, not optional) build with cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
light-run always calls light-runner with
detached+extract. Before 0.16.2, a detached run that extracted artifacts never finalized: the extract seeder hung waiting on a hijacked attach stream that volume-bound containers do not reliably close on Docker Desktop / Windows. The run stayedrunningforever and every caller polling it (including light-process) looped indefinitely.light-runner 0.16.2 finalizes via
inspect()polling + idle-drain instead of stream close (enixCode/light-runner#17), and skips id-less sibling files in the state dir soGET /runsno longer 500s.light-runner^0.16.1->^0.16.2(hard floor: the fix is required, not optional)No source change in light-run, so no defensive guard added: the root cause is fixed upstream in
listStates, andlistRunsis the only consumer that maps over it.build with cc