Skip to content

Add serialization for parameter arrays #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add serialization for parameter arrays #10

merged 1 commit into from
Sep 21, 2023

Conversation

@alexander-efremov
Copy link
Contributor

@alexander-efremov alexander-efremov commented Sep 20, 2023 •
edited
Loading

  • It doesn't suit for nested arrays
  • Some of the object types can be serialized improperly, need to add a separate logic to serialize them (see serialization of BigInteger type).

@alexander-efremov alexander-efremov force-pushed the feature/support-serialization-of-param-arrays branch from 4caae1d to 09a9301 Compare September 20, 2023 06:59
@leonardocustodio leonardocustodio mentioned this pull request Sep 20, 2023
Closed
@leonardocustodio leonardocustodio self-requested a review September 21, 2023 00:23
@leonardocustodio leonardocustodio added the bug Something isn't working label Sep 21, 2023
@leonardocustodio
Copy link
Contributor

@alexander-efremov can you sign the commit? Can't merge it without a signature

@alexander-efremov
wip
be7a2f9 
Signed-off-by: Alexander Efremov <alexander.efremov@enjin.io>
@alexander-efremov alexander-efremov force-pushed the feature/support-serialization-of-param-arrays branch from 09a9301 to be7a2f9 Compare September 21, 2023 05:49
@alexander-efremov
Copy link
Contributor Author

done, @leonardocustodio

@leonardocustodio leonardocustodio merged commit 6102bbd into enjin:master Sep 21, 2023
@alexander-efremov alexander-efremov deleted the feature/support-serialization-of-param-arrays branch September 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leonardocustodio leonardocustodio leonardocustodio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-efremov @leonardocustodio