Serialize array of dictionaries correctly #9
Conversation
| { | ||
| writer.WritePropertyName(variable.Key); | ||
| writer.WriteRawValue(JsonSerializer.Serialize(variable.Value, options)); | ||
| if (variable.Value != null && variable.Value.GetType().IsGenericType && variable.Value.GetType().GetGenericTypeDefinition() == typeof(List<>)) |
There was a problem hiding this comment.
Would be great if there could be test cases for various scenarios here. Looks like maybe this unit test is meant to cover this functionality and could be expanded?
| writer.WriteStartArray(); | ||
| writer.WriteStartObject(); | ||
|
|
||
| foreach (KeyValuePair<string, object?> parameter in graphQlParameter.Parameters) |
There was a problem hiding this comment.
This probably doesn't work if there are nested arrays. I don't know if that ever happens in Enjin schemas though so maybe that is fine.
There was a problem hiding this comment.
You are right, I will make a recursive function though I wonder if there isn't another way, I mean this whole function is called recursively already and it goes inside each the objects and the objects of ojects and decodes them fine. Only for arrays it seems to fail, so I wonder if this can't be fixed in another way, I will give another thought tomorrow.
|
Superseeded by #10 |
No description provided.