Make Decimal constructors private#12615
Merged
Conversation
Akirathan
added
CI: No changelog needed
Akirathan
requested review from
AdRiley,
GregoryTravis,
jdunkerley,
marthasharkey and
radeusgd
as code owners
github-actions
bot
added
the
-libs-API-change-Base
AdRiley
approved these changes
Mar 24, 2025
GregoryTravis
approved these changes
Mar 24, 2025
JaroslavTulach
approved these changes
Mar 25, 2025
Member
JaroslavTulach
left a comment
JaroslavTulach
left a comment
There was a problem hiding this comment.
I am glad the constructors aren't really visible to end users.
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Statement_Setter.enso
Show resolved
Hide resolved
| ## module Standard.Base.Data.Decimal | ||
| - type Decimal | ||
| - From_Float big_decimal:Standard.Base.Data.Decimal.BigDecimal original_value:Standard.Base.Data.Numbers.Float | ||
| - Value big_decimal:Standard.Base.Data.Decimal.BigDecimal |
Member
There was a problem hiding this comment.
This is great, thank you!
farmaazon
pushed a commit
that referenced
this pull request
Mar 25, 2025
* Make Decimal constructors private * Do not use private Decimal field from Standard.Table * Regenerate API docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10799
Pull Request Description
Declare
Decimalconstructors asprivate.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.