Skip to content

Comments

Add more telemetry info during LS start#12620

Merged
mergify[bot] merged 1 commit intodevelopfrom
wip/akirathan/lang-server-init-msg-more-info
Mar 24, 2025
Merged

Add more telemetry info during LS start#12620
mergify[bot] merged 1 commit intodevelopfrom
wip/akirathan/lang-server-init-msg-more-info

Conversation

@Akirathan
Copy link
Contributor

@Akirathan Akirathan commented Mar 24, 2025 •
edited
Loading

Pull Request Description

Added some telemetry about OS, CPU, and RAM during language server initialization:

pasted

Inspiration from:

Tested on java -jar project-manager.jar as well as project-manager NI.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan self-assigned this Mar 24, 2025
@Akirathan Akirathan requested a review from jdunkerley March 24, 2025 15:44
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 24, 2025
@enso-bot enso-bot bot mentioned this pull request Mar 24, 2025
Closed
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 24, 2025
@mergify mergify bot merged commit 78e87a2 into develop Mar 24, 2025
71 of 74 checks passed
@mergify mergify bot deleted the wip/akirathan/lang-server-init-msg-more-info branch March 24, 2025 21:54
@jdunkerley jdunkerley added this to the 2025-Q1 Release milestone Mar 25, 2025
farmaazon pushed a commit that referenced this pull request Mar 25, 2025
@farmaazon
Add more telemetry info during LS start (#12620)
1c34a29 
Added some telemetry about OS, CPU, and RAM during language server initialization:

![pasted](https://github.com/user-attachments/assets/c7965e6a-e0d9-49c2-96fd-b50df9152d13)

Inspiration from:
- https://github.com/apache/netbeans/blob/master/platform/uihandler/src/org/netbeans/modules/uihandler/CPUInfo.java
- https://github.com/apache/netbeans/blob/master/platform/core.ui/src/org/netbeans/core/ui/warmup/DiagnosticTask.java#L75
- https://github.com/apache/netbeans/blob/master/platform/uihandler/src/org/netbeans/modules/uihandler/ScreenSize.java

Tested on `java -jar project-manager.jar` as well as `project-manager` NI.
@Akirathan Akirathan mentioned this pull request Mar 25, 2025
Merged
5 tasks
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
Fix booting of native language server (#12639)
f90a331 
#12620 broken booting of NI LS:
```
Exception in thread "main" javax.management.RuntimeErrorException: org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() without it being registered for runtime reflection. Add public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() to the reflection metadata to solve this problem. See https://www.graalvm.org/latest/reference-manual/native-image/metadata/#reflection for help.
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:821)
[INFO] [2025-03-25T12:55:55.688] [org.enso.languageserver.boot.LanguageServerComponent] Starting Language Server...
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:832)
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:640)
at java.management@21.0.2/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:679)
at org.enso.languageserver.boot.MainModule.initialTelemetry(MainModule.scala:545)
at org.enso.languageserver.boot.MainModule.<init>(MainModule.scala:85)
at org.enso.languageserver.boot.LanguageServerComponent.start(LanguageServerComponent.scala:47)
at org.enso.languageserver.boot.LanguageServerApp$.run(LanguageServerApp.scala:37)
at org.enso.languageserver.boot.LanguageServerApp.run(LanguageServerApp.scala)
at org.enso.languageserver.boot.LanguageServerRunner.runLanguageServer(LanguageServerRunner.java:25)
at org.enso.runner.common.LanguageServerApi.launchLanguageServer(LanguageServerApi.java:28)
at org.enso.runner.Main.launch(Main.java:1495)
at org.enso.runner.Main.launch(Main.java:1444)
at org.enso.runner.Main.main(Main.java:1063)
Caused by: org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() without it being registered for runtime reflection. Add public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() to the reflection metadata to solve this problem. See https://www.graalvm.org/latest/reference-manual/native-image/metadata/#reflection for help.
at org.graalvm.nativeimage.builder/com.oracle.svm.core.reflect.MissingReflectionRegistrationUtils.forQueriedOnlyExecutable(MissingReflectionRegistrationUtils.java:72)
at java.base@21.0.2/java.lang.reflect.Method.acquireMethodAccessor(Method.java:77)
at java.base@21.0.2/java.lang.reflect.Method.invoke(Method.java:577)
at java.base@21.0.2/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:217)
at java.management@21.0.2/com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
at java.management@21.0.2/com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:115)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:52)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:236)
at java.management@21.0.2/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
at java.management@21.0.2/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:636)
... 11 more
```

This PR fixes that - adds the necessary method to reflect config.

This time, I have manually tested:
```
$ env ENSO_LAUNCHER=native ./run --skip-version-check ide build --mode staging
$ ./dist/ide/enso-linux-x86_64-0.0.0-dev.AppImage
```

Collected telemetry seems OK:
![Pasted image](https://github.com/user-attachments/assets/908d90ac-6bbb-4ff8-bf4a-8bc25ec87c90)
farmaazon pushed a commit that referenced this pull request Mar 26, 2025
@farmaazon
Fix booting of native language server (#12639)
7d3f6a5 
#12620 broken booting of NI LS:
```
Exception in thread "main" javax.management.RuntimeErrorException: org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() without it being registered for runtime reflection. Add public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() to the reflection metadata to solve this problem. See https://www.graalvm.org/latest/reference-manual/native-image/metadata/#reflection for help.
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:821)
[INFO] [2025-03-25T12:55:55.688] [org.enso.languageserver.boot.LanguageServerComponent] Starting Language Server...
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:832)
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:640)
at java.management@21.0.2/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:679)
at org.enso.languageserver.boot.MainModule.initialTelemetry(MainModule.scala:545)
at org.enso.languageserver.boot.MainModule.<init>(MainModule.scala:85)
at org.enso.languageserver.boot.LanguageServerComponent.start(LanguageServerComponent.scala:47)
at org.enso.languageserver.boot.LanguageServerApp$.run(LanguageServerApp.scala:37)
at org.enso.languageserver.boot.LanguageServerApp.run(LanguageServerApp.scala)
at org.enso.languageserver.boot.LanguageServerRunner.runLanguageServer(LanguageServerRunner.java:25)
at org.enso.runner.common.LanguageServerApi.launchLanguageServer(LanguageServerApi.java:28)
at org.enso.runner.Main.launch(Main.java:1495)
at org.enso.runner.Main.launch(Main.java:1444)
at org.enso.runner.Main.main(Main.java:1063)
Caused by: org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() without it being registered for runtime reflection. Add public default long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize() to the reflection metadata to solve this problem. See https://www.graalvm.org/latest/reference-manual/native-image/metadata/#reflection for help.
at org.graalvm.nativeimage.builder/com.oracle.svm.core.reflect.MissingReflectionRegistrationUtils.forQueriedOnlyExecutable(MissingReflectionRegistrationUtils.java:72)
at java.base@21.0.2/java.lang.reflect.Method.acquireMethodAccessor(Method.java:77)
at java.base@21.0.2/java.lang.reflect.Method.invoke(Method.java:577)
at java.base@21.0.2/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:217)
at java.management@21.0.2/com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
at java.management@21.0.2/com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:115)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:52)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:236)
at java.management@21.0.2/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
at java.management@21.0.2/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
at java.management@21.0.2/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
at java.management@21.0.2/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:636)
... 11 more
```

This PR fixes that - adds the necessary method to reflect config.

This time, I have manually tested:
```
$ env ENSO_LAUNCHER=native ./run --skip-version-check ide build --mode staging
$ ./dist/ide/enso-linux-x86_64-0.0.0-dev.AppImage
```

Collected telemetry seems OK:
![Pasted image](https://github.com/user-attachments/assets/908d90ac-6bbb-4ff8-bf4a-8bc25ec87c90)
@Akirathan Akirathan mentioned this pull request Jun 23, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4e6 4e6 4e6 approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@Akirathan Akirathan

Labels

CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Milestone

2025-Q1 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@Akirathan @4e6 @jdunkerley @JaroslavTulach