Skip to content

Comments

Add nested dropdowns to Filter Condition#12642

Merged
AdRiley merged 2 commits intodevelopfrom
wip/adr/add-nested-widgets-to-filter-condition
Mar 27, 2025
Merged

Add nested dropdowns to Filter Condition#12642
AdRiley merged 2 commits intodevelopfrom
wip/adr/add-nested-widgets-to-filter-condition

Conversation

@AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 26, 2025

Pull Request Description

Libs side of nested dropdowns. NOT for the 2025.1 release.

Screen.Recording.2025-03-26.at.09.42.08.mov

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 26, 2025
@AdRiley AdRiley added this to the 2025-Q2 Release milestone Mar 26, 2025
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'd prefer is_nothing and not_nothing in the top level as very useful

Boolean and Floating should not be nested into is/not. I think should appear as Booleand and Numeric.
Likewise empty/not empty should be in Text.

@AdRiley AdRiley merged commit 32eebaa into develop Mar 27, 2025
66 of 67 checks passed
@AdRiley AdRiley deleted the wip/adr/add-nested-widgets-to-filter-condition branch March 27, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants