Skip to content

Use getAsset api to retreive the current directory instead of listDirectory #12682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MrFlashAccount merged 3 commits into from
May 13, 2025
Merged

Use getAsset api to retreive the current directory instead of listDirectory #12682

MrFlashAccount merged 3 commits into from
May 13, 2025

Conversation

@MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Mar 31, 2025 •
edited
Loading

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1725

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Mar 31, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Mar 31, 2025
@github-actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@PabloBuchu
Copy link
Contributor

PabloBuchu commented Apr 15, 2025

Can we undraft this or is it still blocked by something?

@MrFlashAccount
Copy link
Contributor Author

MrFlashAccount commented Apr 15, 2025

@PabloBuchu yeah, we're missing the getAsset api on the pm side

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/get-asset-api branch 2 times, most recently from 0dacc24 to b585d52 Compare April 25, 2025 10:16
@MrFlashAccount MrFlashAccount marked this pull request as ready for review April 28, 2025 08:41
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/get-asset-api branch 2 times, most recently from d79fab6 to 86370dc Compare May 9, 2025 08:46
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/get-asset-api branch from 86370dc to d658a23 Compare May 9, 2025 15:33
@MrFlashAccount MrFlashAccount merged commit b3de5b6 into develop May 13, 2025
63 of 65 checks passed
@MrFlashAccount MrFlashAccount deleted the wip/sergeigarin/get-asset-api branch May 13, 2025 08:46
Frizi pushed a commit that referenced this pull request May 13, 2025
@MrFlashAccount @Frizi
Use getAsset api to retreive the current directory instead of `list…
24f25cb 
…Directory` (#12682)

* Fetch an asset in DriveNavigation

* Small fix

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@Frizi Frizi Awaiting requested review from Frizi

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels

CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrFlashAccount @PabloBuchu