-
Notifications
You must be signed in to change notification settings - Fork 334
Implement Contextual help component #12764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 Storybook is successfully deployed!📊 Dashboard:
|
app/gui/src/dashboard/components/AriaComponents/Dialog/DialogTrigger.tsx
Show resolved
Hide resolved
| return ( | ||
| <div className="grid grid-cols-3 gap-8 p-8"> | ||
| <div className="flex justify-center"> | ||
| <ContextualHelp placement="top start">{content}</ContextualHelp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the notifications PR having been merged in, feel free to try StoryVariants!
enso/app/gui/src/dashboard/components/Icon/Icon.stories.tsx
Lines 107 to 120 in 47e66da
| export const AvailableIconsWithStatusBadge: Story = { | |
| render: () => ( | |
| <StoryVariants | |
| columns="9" | |
| render={(props: IconProps) => ( | |
| <StatusBadge color="danger"> | |
| <Icon {...props} /> | |
| </StatusBadge> | |
| )} | |
| toProps={(icon) => ({ icon })} | |
| variants={iconNames} | |
| /> | |
| ), | |
| } |
enso/app/gui/src/dashboard/components/AriaComponents/Text/Text.stories.tsx
Lines 36 to 52 in 47e66da
| export const Colors: Story = { | |
| render: () => ( | |
| <StoryVariants | |
| render={Text} | |
| toProps={(props) => ({ ...args, ...props })} | |
| toLabel={({ color }) => color} | |
| variants={[ | |
| { color: 'primary' }, | |
| { color: 'danger' }, | |
| { color: 'invert', className: 'bg-primary px-2 rounded-md' }, | |
| { color: 'success' }, | |
| { color: 'disabled' }, | |
| { color: 'custom', className: 'text-youtube' }, | |
| ]} | |
| /> | |
| ), | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback is welcome/appreciated
b2d2f7a to
2dfcbe3
Compare
Pull Request Description
This PR adds an ability to specify a rich contextual help to any form component:

This PR doesn't do any changes to production code! Only adds a new property.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.