Skip to content

Conversation

@MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Apr 7, 2025

Pull Request Description

This PR adds an ability to specify a rich contextual help to any form component:
CleanShot 2025-04-23 at 14 11 54@2x

This PR doesn't do any changes to production code! Only adds a new property.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Apr 7, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Apr 7, 2025
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

return (
<div className="grid grid-cols-3 gap-8 p-8">
<div className="flex justify-center">
<ContextualHelp placement="top start">{content}</ContextualHelp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the notifications PR having been merged in, feel free to try StoryVariants!

export const AvailableIconsWithStatusBadge: Story = {
render: () => (
<StoryVariants
columns="9"
render={(props: IconProps) => (
<StatusBadge color="danger">
<Icon {...props} />
</StatusBadge>
)}
toProps={(icon) => ({ icon })}
variants={iconNames}
/>
),
}

export const Colors: Story = {
render: () => (
<StoryVariants
render={Text}
toProps={(props) => ({ ...args, ...props })}
toLabel={({ color }) => color}
variants={[
{ color: 'primary' },
{ color: 'danger' },
{ color: 'invert', className: 'bg-primary px-2 rounded-md' },
{ color: 'success' },
{ color: 'disabled' },
{ color: 'custom', className: 'text-youtube' },
]}
/>
),
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback is welcome/appreciated

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/contextual-help branch from b2d2f7a to 2dfcbe3 Compare May 20, 2025 11:56
@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2025
@mergify mergify bot merged commit 3fb6fa3 into develop May 20, 2025
62 of 64 checks passed
@mergify mergify bot deleted the wip/sergeigarin/contextual-help branch May 20, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants